Skip to content

Add type hovers for jkinds #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liam923 merged 3 commits into from
Dec 4, 2025
Merged

Add type hovers for jkinds #200

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6a1e4a1
Add type hovers for jkinds
liam923 Nov 21, 2025
f431359
Add more tests
liam923 Dec 3, 2025
9f789f9
Add more tests
liam923 Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions tests/test-dirs/type-enclosing/jkind-hover.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,10 @@ Test that hovering over jkind annotations shows their full expansion.
> type t6 : bits32
> type t7 : bits32 mod portable contended
> type t8 : void
> module type S = sig
> val f : ('a : immediate). 'a -> 'a
> val g : ('b : bits32) -> ('b : value mod portable)
> end
> EOF

$ hover 1 14 1
Expand Down Expand Up @@ -94,3 +98,20 @@ Test that hovering over jkind annotations shows their full expansion.
type t8 : void
^
"void" : "void mod non_float"

$ hover 10 18 1
val f : ('a : immediate). 'a -> 'a
^
"immediate)" : "value mod global many stateless immutable external_ non_float"
Copy link
Contributor

@dkalinichenko-js dkalinichenko-js Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does it print the closing bracket here?

Copy link
Contributor Author

@liam923 liam923 Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't invesitgated this much, but I suspect that it's a bug in the parser where the wrong location is being recorded. There's some other tests in this file where an extra following character is printed (but in those other cases, it's a space rather than a paren).


$ hover 11 18 1
val g : ('b : bits32) -> ('b : value mod portable)
^
"bits32)" : "bits32 mod non_float"

# CR-someday: This is failing because of poor error recovery.
$ hover 11 35 2
val g : ('b : bits32) -> ('b : value mod portable)
^
"('b : value mod portable)" : "'a"
"('b : bits32) -> ('b : value mod portable)" : "'b -> 'a"