Add test for ignored flags #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkalinichenko-js
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merlin gets invoked with the same flags as the compiler. Thus, it must know what to do with every compiler flag. Some of them it actually parses and does something with, but there's also a long list of ignored flags. Although we try to be careful about Merlin keeping these flags in sync with the compiler, it's easy to make a mistake here, and we have in the past. This PR adds a test that prints out all the compiler flags that Merlin doesn't know how to handle.
When I did this, I discovered a list of ~30 compiler flags that Merlin currently doesn't understand, which I added to the list of ignored flags.