Simplified Authentication interface (#237)

Author: merlimat

client-api/src/main/java/io/oxia/client/api/Authentication.java

@@ -23,6 +23,14 @@
  */
 public interface Authentication {
 
+    /**
+     * Plugins which use ":" and/or "," in a configuration parameter value need to implement this
+     * interface.
+     *
+     * @param encodedAuthParamString the encoded configuration parameter value
+     */
+    void configure(String encodedAuthParamString);
+
     /**
      * Generates a set of credentials represented as key-value pairs.
      *

client-api/src/main/java/io/oxia/client/api/EncodedAuthenticationParameterSupport.java

@@ -17,7 +17,6 @@
 
 import com.google.common.base.Strings;
 import io.oxia.client.api.Authentication;
-import io.oxia.client.api.EncodedAuthenticationParameterSupport;
 import io.oxia.client.api.exceptions.UnsupportedAuthenticationException;
 import java.lang.reflect.Constructor;
 
@@ -31,9 +30,7 @@ public static Authentication create(String authPluginClassName, String authParam
                 Constructor<?> declaredConstructor = authClass.getDeclaredConstructor();
                 declaredConstructor.setAccessible(true);
                 Authentication auth = (Authentication) declaredConstructor.newInstance();
-                if (auth instanceof EncodedAuthenticationParameterSupport) {
-                    ((EncodedAuthenticationParameterSupport) auth).configure(authParamsString);
-                }
+                auth.configure(authParamsString);
                 return auth;
             }
         } catch (Throwable t) {

client/src/main/java/io/oxia/client/auth/AuthenticationFactory.java

@@ -16,7 +16,6 @@
 package io.oxia.client.auth;
 
 import io.oxia.client.api.Authentication;
-import io.oxia.client.api.EncodedAuthenticationParameterSupport;
 import java.io.IOException;
 import java.net.URI;
 import java.nio.file.Files;
@@ -25,7 +24,7 @@
 import java.util.Map;
 import java.util.function.Supplier;
 
-public class TokenAuthentication implements Authentication, EncodedAuthenticationParameterSupport {
+public class TokenAuthentication implements Authentication {
 
     private static final String AUTHORIZATION_KEY = "Authorization";
     private static final String BEARER_TYPE = "Bearer";