Skip to content

Commit 05fdf54

Browse files
rowLabel and onRemoveItem not optional
1 parent 667c483 commit 05fdf54

1 file changed

Lines changed: 9 additions & 8 deletions

File tree

app/ui/lib/MiniTable.tsx

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ export type DataMiniTableProps<T> = {
115115
items: T[]
116116
columns: Column<T>[]
117117
rowKey: (item: T, index: number) => string
118-
rowLabel?: (item: T, index: number) => string
118+
rowLabel: (item: T, index: number) => string
119119
onRemoveItem: (item: T, index: number) => void
120120
removeLabel?: (item: T, index: number) => string
121121
emptyState: {
@@ -151,19 +151,20 @@ export function DataMiniTable<T>({
151151
<Row
152152
tabIndex={0}
153153
aria-rowindex={index + 1}
154-
aria-label={rowLabel?.(item, index)}
154+
aria-label={rowLabel(item, index)}
155155
key={rowKey(item, index)}
156156
>
157157
{columns.map((column, colIndex) => (
158158
<Cell key={colIndex}>{column.render(item, index)}</Cell>
159159
))}
160160

161-
{onRemoveItem && (
162-
<RemoveCell
163-
onClick={() => onRemoveItem(item, index)}
164-
label={removeLabel?.(item, index) || `Remove item ${index + 1}`}
165-
/>
166-
)}
161+
<RemoveCell
162+
onClick={() => onRemoveItem(item, index)}
163+
label={
164+
removeLabel?.(item, index) ||
165+
`Remove ${ariaLabel.toLowerCase()} ${index + 1}`
166+
}
167+
/>
167168
</Row>
168169
))
169170
) : (

0 commit comments

Comments
 (0)