Fix code that assumes timer notification => timer fired

There are two main reasons why a timer notification bit might be set
without the timer firing:

1. Subtle state machine bug in previous iteration (not super common but
   it has happened).

2. Another task, accidentally or deliberately, posting to the bit.

This changes the cases I could easily find to check that their timers
have actually expired before acting.

Author: cbiffle

drv/cosmo-hf/src/hf.rs

@@ -786,7 +786,9 @@ impl NotificationHandler for ServerImpl {
     }
 
     fn handle_notification(&mut self, bits: u32) {
-        if (bits & notifications::TIMER_MASK) != 0 {
+        if (bits & notifications::TIMER_MASK) != 0
+            && userlib::sys_get_timer().deadline.is_none()
+        {
             self.step_hash();
         }
     }

drv/cosmo-seq-server/src/main.rs

@@ -893,7 +893,9 @@ impl NotificationHandler for ServerImpl {
             self.handle_sequencer_interrupt();
         }
 
-        if (bits & notifications::TIMER_MASK) == 0 {
+        if (bits & notifications::TIMER_MASK) == 0
+            || sys_get_timer().deadline.is_some()
+        {
             return;
         }
         let state = self.log_state_registers();

drv/gimlet-hf-server/src/main.rs

@@ -948,7 +948,9 @@ impl NotificationHandler for ServerImpl {
     }
 
     fn handle_notification(&mut self, bits: u32) {
-        if (bits & notifications::TIMER_MASK) != 0 {
+        if (bits & notifications::TIMER_MASK) != 0
+            && userlib::sys_get_timer().deadline.is_none()
+        {
             self.step_hash();
         }
     }

drv/gimlet-seq-server/src/main.rs

@@ -545,7 +545,9 @@ impl<S: SpiServer> NotificationHandler for ServerImpl<S> {
             self.vcore.handle_notification(self.ereport_buf);
         }
 
-        if (bits & notifications::TIMER_MASK) == 0 {
+        if (bits & notifications::TIMER_MASK) == 0
+            || sys_get_timer().deadline.is_some()
+        {
             return;
         }
 

drv/ignition-server/src/main.rs

@@ -421,6 +421,10 @@ impl idol_runtime::NotificationHandler for ServerImpl {
     }
 
     fn handle_notification(&mut self, _bits: u32) {
+        if sys_get_timer().deadline.is_some() {
+            return;
+        }
+
         let start = sys_get_timer().now;
 
         // Only poll the presence summary if the port count seems reasonable. A

drv/meanwell/src/main.rs

@@ -112,6 +112,10 @@ impl NotificationHandler for ServerImpl {
     }
 
     fn handle_notification(&mut self, _bits: u32) {
+        if userlib::sys_get_timer().deadline.is_some() {
+            return;
+        }
+
         let user_leds =
             drv_user_leds_api::UserLeds::from(USER_LEDS.get_task_id());
 

drv/minibar-ignition-server/src/main.rs

@@ -399,6 +399,10 @@ impl idol_runtime::NotificationHandler for ServerImpl {
     }
 
     fn handle_notification(&mut self, _bits: u32) {
+        if sys_get_timer().deadline.is_some() {
+            return;
+        }
+
         let start = sys_get_timer().now;
 
         // Only poll the presence summary if the port count seems reasonable. A

drv/minibar-seq-server/src/main.rs

@@ -134,7 +134,9 @@ impl NotificationHandler for ServerImpl {
     }
 
     fn handle_notification(&mut self, bits: u32) {
-        if (bits & notifications::TIMER_MASK) == 0 {
+        if (bits & notifications::TIMER_MASK) == 0
+            || sys_get_timer().deadline.is_some()
+        {
             return;
         }
         let start = sys_get_timer().now;

drv/psc-seq-server/src/main.rs

@@ -469,7 +469,10 @@ fn main() -> ! {
 
         // Wait for a pin change or timer.
         let n = sys_recv_notification(sleep_notifications);
-        if n & notifications::TIMER_MASK != 0 {
+        // If the timer bit is set _and the timer has actually fired_...
+        if n & notifications::TIMER_MASK != 0
+            && sys_get_timer().deadline.is_none()
+        {
             // Reset our timer forward.
             sys_set_timer(
                 Some(now.saturating_add(POLL_MS)),

drv/sidecar-seq-server/src/main.rs

@@ -775,6 +775,10 @@ impl NotificationHandler for ServerImpl {
     }
 
     fn handle_notification(&mut self, _bits: u32) {
+        if sys_get_timer().deadline.is_some() {
+            return;
+        }
+
         let start = sys_get_timer().now;
 
         // Determine if the front IO board has been initialized and no further