Use NotificationBits in Idol (#2233)

This is mostly mechanical, with one logical change: I removed the timer
from `medusa-seq-server`, because it wasn't doing anything.

Author: mkeeter

Cargo.lock

@@ -125,7 +125,6 @@ task-slots = [
     "auxflash",
     "packrat",
     {front_io = "ecp5_front_io"}]
-notifications = ["timer"]
 
 [tasks.transceivers]
 name = "drv-transceivers-server"

app/medusa/base.toml

@@ -484,7 +484,7 @@ impl NotificationHandler for ServerImpl {
         0
     }
 
-    fn handle_notification(&mut self, _bits: u32) {
+    fn handle_notification(&mut self, _bits: userlib::NotificationBits) {
         unreachable!()
     }
 }

drv/auxflash-server/src/main.rs

@@ -785,10 +785,8 @@ impl NotificationHandler for ServerImpl {
         notifications::TIMER_MASK
     }
 
-    fn handle_notification(&mut self, bits: u32) {
-        if (bits & notifications::TIMER_MASK) != 0
-            && userlib::sys_get_timer().deadline.is_none()
-        {
+    fn handle_notification(&mut self, bits: userlib::NotificationBits) {
+        if bits.has_timer_fired(notifications::TIMER_MASK) {
             self.step_hash();
         }
     }

drv/cosmo-hf/src/hf.rs

@@ -888,14 +888,12 @@ impl NotificationHandler for ServerImpl {
         notifications::TIMER_MASK | notifications::SEQ_IRQ_MASK
     }
 
-    fn handle_notification(&mut self, bits: u32) {
-        if (bits & notifications::SEQ_IRQ_MASK) != 0 {
+    fn handle_notification(&mut self, bits: userlib::NotificationBits) {
+        if bits.check_notification_mask(notifications::SEQ_IRQ_MASK) {
             self.handle_sequencer_interrupt();
         }
 
-        if (bits & notifications::TIMER_MASK) == 0
-            || sys_get_timer().deadline.is_some()
-        {
+        if !bits.has_timer_fired(notifications::TIMER_MASK) {
             return;
         }
         let state = self.log_state_registers();

drv/cosmo-seq-server/src/main.rs

@@ -97,7 +97,7 @@ impl NotificationHandler for EepromServer {
         0
     }
 
-    fn handle_notification(&mut self, _bits: u32) {
+    fn handle_notification(&mut self, _bits: userlib::NotificationBits) {
         unreachable!()
     }
 }

drv/eeprom/src/main.rs

@@ -608,7 +608,7 @@ impl<'a, Device: Fpga<'a> + FpgaUserDesign> idol_runtime::NotificationHandler
         0
     }
 
-    fn handle_notification(&mut self, _bits: u32) {
+    fn handle_notification(&mut self, _bits: userlib::NotificationBits) {
         unreachable!()
     }
 }

drv/fpga-server/src/main.rs

@@ -947,10 +947,8 @@ impl NotificationHandler for ServerImpl {
         notifications::TIMER_MASK
     }
 
-    fn handle_notification(&mut self, bits: u32) {
-        if (bits & notifications::TIMER_MASK) != 0
-            && userlib::sys_get_timer().deadline.is_none()
-        {
+    fn handle_notification(&mut self, bits: userlib::NotificationBits) {
+        if bits.has_timer_fired(notifications::TIMER_MASK) {
             self.step_hash();
         }
     }

drv/gimlet-hf-server/src/main.rs

@@ -540,14 +540,12 @@ impl<S: SpiServer> NotificationHandler for ServerImpl<S> {
         notifications::TIMER_MASK | self.vcore.mask()
     }
 
-    fn handle_notification(&mut self, bits: u32) {
-        if (bits & self.vcore.mask()) != 0 {
+    fn handle_notification(&mut self, bits: userlib::NotificationBits) {
+        if bits.check_notification_mask(self.vcore.mask()) {
             self.vcore.handle_notification(self.ereport_buf);
         }
 
-        if (bits & notifications::TIMER_MASK) == 0
-            || sys_get_timer().deadline.is_some()
-        {
+        if !bits.has_timer_fired(notifications::TIMER_MASK) {
             return;
         }
 

drv/gimlet-seq-server/src/main.rs

@@ -189,7 +189,7 @@ impl NotificationHandler for ServerImpl {
         0
     }
 
-    fn handle_notification(&mut self, _bits: u32) {
+    fn handle_notification(&mut self, _bits: userlib::NotificationBits) {
         unreachable!()
     }
 }