removing a bgp peer config does not remove it from maghemite

[rcgoodfellow]

Removing a BGP peer via

oxide system networking bgp peer del [...]

Running

oxide system networking switch-port-settings show

shows the peer has been deleted in omicron's state. However, the peer is not deleted from maghemite.

[internet-diglett]

It looks like we're logging what peers we're requesting in the Nexus background task:

omicron/nexus/src/app/background/tasks/sync_switch_configuration.rs

Lines 821 to 825 in b50fe3a

	info!(
	&log,
	"applying bgp config";
	"switch_location" => ?location,
	"config" => ?config,

So we might be able to bisect the problem here by replicating the problem in a4x2 and then checking this log message to see if the confusion is happening on the nexus side or the mgd side.

[rcgoodfellow]

I just tried this in a4x2, and removing the peer from Omicron did, in fact, remove it from Maghemite. I will try a few different configurations to try and repro this.