Skip to content

Commit 3a382aa

Browse files
authored
Clean up lingering quantile logic. (#43)
We dropped streaming quantile estimates in #30 but left a few references to that feature behind. This cleans up remaining references to the deprecated quantile feature.
1 parent 1716cf0 commit 3a382aa

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

receiver/oxidemetricsreceiver/scraper.go

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -265,10 +265,6 @@ func (s *oxideScraper) Scrape(ctx context.Context) (pmetric.Metrics, error) {
265265

266266
switch {
267267
// Handle histograms.
268-
//
269-
// Note: OxQL histograms include both buckets and counts, as well as a handful of
270-
// preselected quantiles estimated using the P² algorithm. We extract the buckets
271-
// and counts as an otel histogram, and the quantiles as a gauge.
272268
case slices.Contains([]oxide.ValueArrayType{oxide.ValueArrayTypeIntegerDistribution, oxide.ValueArrayTypeDoubleDistribution}, v0.Values.Type()):
273269
measure := m.SetEmptyHistogram()
274270
// Always set aggregation temporality to cumulative. OxQL has both delta and
@@ -277,9 +273,6 @@ func (s *oxideScraper) Scrape(ctx context.Context) (pmetric.Metrics, error) {
277273
// metrics are effectively of type cumulative for our purposes.
278274
measure.SetAggregationTemporality(pmetric.AggregationTemporalityCumulative)
279275

280-
quantiles := sm.Metrics().AppendEmpty()
281-
quantiles.SetName(fmt.Sprintf("%s:quantiles", table.Name))
282-
283276
if err := addHistogram(
284277
measure.DataPoints(),
285278
table,

0 commit comments

Comments
 (0)