update to rust 1.84 (#1105)

Author: ahl

cli/src/cli_builder.rs

@@ -104,7 +104,7 @@ pub struct NewCli<'a> {
     runner: CommandBuilder<'a>,
 }
 
-impl<'a> Default for NewCli<'a> {
+impl Default for NewCli<'_> {
     fn default() -> Self {
         let mut parser = OxideCli::command().name("oxide").subcommand_required(true);
         let mut runner = CommandBuilder::default();

cli/src/cmd_timeseries/dashboard.rs

@@ -491,7 +491,7 @@ struct TimeseriesGraph<'a> {
     graph_state: &'a GraphState,
 }
 
-impl<'a> Widget for TimeseriesGraph<'a> {
+impl Widget for TimeseriesGraph<'_> {
     fn render(self, area: ratatui::prelude::Rect, buf: &mut ratatui::prelude::Buffer)
     where
         Self: Sized,
@@ -549,7 +549,7 @@ struct TimeseriesSchemaTable<'a> {
     graph_state: &'a mut GraphState,
 }
 
-impl<'a> Widget for TimeseriesSchemaTable<'a> {
+impl Widget for TimeseriesSchemaTable<'_> {
     fn render(self, area: ratatui::prelude::Rect, buf: &mut ratatui::prelude::Buffer)
     where
         Self: Sized,
@@ -631,7 +631,7 @@ struct QueryString<'a> {
     query: &'a str,
 }
 
-impl<'a> Widget for QueryString<'a> {
+impl Widget for QueryString<'_> {
     fn render(self, area: ratatui::prelude::Rect, buf: &mut ratatui::prelude::Buffer)
     where
         Self: Sized,

rust-toolchain.toml

@@ -1,3 +1,3 @@
 [toolchain]
-channel = "1.82"
+channel = "1.84"
 profile = "default"

sdk/src/auth.rs

@@ -242,7 +242,7 @@ fn get_profile_auth(
                     (profile_info.host == env_host).then_some(profile_name)
                 })
                 .next()
-                .ok_or_else(|| OxideAuthError::MissingToken(env_host))?
+                .ok_or(OxideAuthError::MissingToken(env_host))?
                 .clone()
         } else {
             let config_path = config_dir.join("config.toml");
@@ -263,7 +263,7 @@ fn get_profile_auth(
         let profile = creds
             .profile
             .get(&profile_name)
-            .ok_or_else(|| OxideAuthError::NoProfile(credentials_path, profile_name))?;
+            .ok_or(OxideAuthError::NoProfile(credentials_path, profile_name))?;
         Ok((profile.host.clone(), profile.token.clone()))
     }
 }

sdk/src/extras/disk.rs

@@ -255,7 +255,7 @@ pub mod types {
         pub cleanup_started: AtomicBool,
     }
 
-    impl<'a> DiskImport<'a> {
+    impl DiskImport<'_> {
         pub async fn run_with_cancel(
             self,
             cancel_rx: oneshot::Receiver<()>,

test-common/src/json_mock.rs

@@ -7,6 +7,24 @@
 //! A Facility to generate valid, random data for types that are
 //! `schemars::JsonSchema + serde::Deserialize`. It generates a JSON value
 //! based on the JSON schema and then deserializes that into the given type.
+//!
+//! Notes
+//! Configuration we might want
+//! - Should we use examples if they're present? Seems like might be a enum
+//!   to select between "ignore examples", "exclusively use examples",
+//!   "choose between generated values and examples (with some weight)",
+//!   "choose examples for scalars (but not complex types)", etc.
+//! - One can imagine situations where it may not be tractable to know a priori
+//!   if a value validates, for example if there were a structure that
+//!   contained a complex regex or a `not` with a complex schema. The consumer
+//!   might want to decide how many times we try to generate a type before
+//!   giving up with an error.
+//! - Maximum array length.
+//!
+//! Do we need something to ensure that recursive types converge? For example,
+//! we could track the depth of an object (per-reference or in absolute terms)
+//! and bias towards simpler types as the depth increases (e.g. preferring to
+//! exclude non-required object properties or shortening arrays).
 
 use std::fmt::Display;
 
@@ -22,25 +40,6 @@ use schemars::{
 use serde::de::DeserializeOwned;
 use serde_json::{json, Number, Value};
 
-/// Notes
-/// Configuration we might want
-/// - Should we use examples if they're present? Seems like might be a enum
-///   to select between "ignore examples", "exclusively use examples",
-///   "choose between generated values and examples (with some weight)",
-///   "choose examples for scalars (but not complex types)", etc.
-/// - One can imagine situations where it may not be tractable to know a priori
-///   if a value validates, for example if there were a structure that
-///   contained a complex regex or a `not` with a complex schema. The consumer
-///   might want to decide how many times we try to generate a type before
-///   giving up with an error.
-/// - Maximum array length.
-///
-///
-/// Do we need something to ensure that recursive types converge? For example,
-/// we could track the depth of an object (per-reference or in absolute terms)
-/// and bias towards simpler types as the depth increases (e.g. preferring to
-/// exclude non-required object properties or shortening arrays).
-
 // TODO This is going to let us have a fixed set of bytes or an RNG.
 pub trait Source: Rng {}
 impl<T> Source for T where T: Rng {}
@@ -417,6 +416,7 @@ fn mock_bool(src: &mut impl Source) -> Result<Value, Error> {
     Ok(json! { b })
 }
 
+#[allow(clippy::manual_div_ceil)]
 fn mock_integer(
     format: &Option<String>,
     number: &Option<Box<NumberValidation>>,