Skip to content

nvme errorneously reports success if guests tries to disable volatile write cache  #493

Open
@luqmana

Description

@luqmana

We always return success if the guest tries to update the Volatile Write Cache feature:

cmds::FeatureIdent::VolatileWriteCache => {
// NVMe 1.0e Figure 66 Identify - Identify Controller Data
// Structure "If a volatile write cache [VWC] is present, then
// the host may ... control whether it is enabled with Set
// Features specifying the Volatile Write Cache feature
// identifier."
cmds::Completion::success()
}

This can potentially cause data loss as the guest will assume that write will be committed on completion.

Metadata

Metadata

Assignees

No one assigned

    Labels

    storageRelated to storage devices/backends.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions