fix: MMNotificationClient callback might be called during game shutdown, prevent a crash

p0358 · p0358 · commit c0d16da0b2df · 2025-01-14T18:54:49.000+01:00
diff --git a/bmedll/MMNotificationClient.cpp b/bmedll/MMNotificationClient.cpp
@@ -44,11 +44,13 @@ HRESULT STDMETHODCALLTYPE MMNotificationClient::QueryInterface(REFIID riid, VOID
 
 HRESULT STDMETHODCALLTYPE MMNotificationClient::OnDefaultDeviceChanged(EDataFlow flow, ERole role, LPCWSTR pwstrDeviceId)
 {
+	if (!IsSDKReady())
+		return;
 	if (role == eMultimedia)
 	{
 		spdlog::info("[MMNotificationClient::OnDefaultDeviceChanged] Default multimedia audio device changed, requesting game's XAudio to restart.");
 		int refresh_rate = *reinterpret_cast<int*>(Util::GetModuleBaseAddress("engine.dll") + 0x7CAEA4);
-		SDK().AddDelayedFunc([] { SDK().GetConCommandManager().ExecuteCommand("sound_reboot_xaudio"); }, refresh_rate);
+		SDK().AddDelayedFunc([] { if (IsSDKReady()) SDK().GetConCommandManager().ExecuteCommand("sound_reboot_xaudio"); }, refresh_rate);
 	}
 	return S_OK;
 }

Original file line number	Diff line number	Diff line change
`@@ -44,11 +44,13 @@ HRESULT STDMETHODCALLTYPE MMNotificationClient::QueryInterface(REFIID riid, VOID`
`44`	`44`
`45`	`45`	`HRESULT STDMETHODCALLTYPE MMNotificationClient::OnDefaultDeviceChanged(EDataFlow flow, ERole role, LPCWSTR pwstrDeviceId)`
`46`	`46`	`{`
	`47`	`+ if (!IsSDKReady())`
	`48`	`+ return;`
`47`	`49`	`if (role == eMultimedia)`
`48`	`50`	`{`
`49`	`51`	`spdlog::info("[MMNotificationClient::OnDefaultDeviceChanged] Default multimedia audio device changed, requesting game's XAudio to restart.");`
`50`	`52`	`int refresh_rate = reinterpret_cast<int>(Util::GetModuleBaseAddress("engine.dll") + 0x7CAEA4);`
`51`		`- SDK().AddDelayedFunc([] { SDK().GetConCommandManager().ExecuteCommand("sound_reboot_xaudio"); }, refresh_rate);`
	`53`	`+ SDK().AddDelayedFunc([] { if (IsSDKReady()) SDK().GetConCommandManager().ExecuteCommand("sound_reboot_xaudio"); }, refresh_rate);`
`52`	`54`	`}`
`53`	`55`	`return S_OK;`
`54`	`56`	`}`