Skip to content

Commit 3f2c85e

Browse files
Merge pull request #364 from esimov/master
Define a global environment variable instead of Sentry
2 parents db7403f + cdb3129 commit 3f2c85e

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

docker-compose.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -64,11 +64,11 @@ services:
6464
- "3000:3000"
6565
- "3001:3001"
6666
environment:
67+
- ENVIRONMENT=development
6768
- JAEGER_AGENT_HOST=jaeger
6869
- JAEGER_SAMPLER_TYPE=const
6970
- JAEGER_SAMPLER_PARAM=1
7071
- JAEGER_SERVICE_NAME=testserver
71-
- SENTRY_ENVIRONMENT=development
7272
- SENTRY_RELEASE=HEAD
7373
- PACE_LIVETEST_INTERVAL=10s
7474
- LOG_FORMAT=console

maintenance/errors/README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@
99

1010
## Environment based configuration
1111

12+
* `ENVIRONMENT`
13+
* Default environment of sentry reported in the dashboard
1214
* `SENTRY_DSN`
1315
* URL of the sentry DSN
14-
* `SENTRY_ENVIRONMENT`
15-
* Environment of sentry reported in the dashboard
1616
* `SENTRY_RELEASE`
1717
* Name of the release e.g. git commit or similar

maintenance/errors/raven/client.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -376,7 +376,7 @@ func newClient(tags map[string]string) *Client {
376376
log.Warnf("DSN environment was set to %q but failed: %v", dsn, err)
377377
}
378378
client.SetRelease(os.Getenv("SENTRY_RELEASE"))
379-
client.SetEnvironment(os.Getenv("SENTRY_ENVIRONMENT"))
379+
client.SetEnvironment(os.Getenv("ENVIRONMENT"))
380380
return client
381381
}
382382

0 commit comments

Comments
 (0)