Make "app_clip_default_experience_metadata_path" optional

Author: telip007

deliver/lib/deliver/loader.rb

@@ -121,9 +121,10 @@ def self.load_app_screenshots(root, ignore_validation)
     # will cause an error. There may only be a max of one image per language and each image must be
     # exactly 1800x1200.
     #
-    # @param root [String] A directory path @param ignore_validation [String] Set false not to raise
-    # the error when finding invalid folder name @return [Array<Deliver::AppClipHeaderImage>] The
-    # list of AppClipHeaderImage that exist under given `root` directory
+    # @param root [String] A directory path
+    # @param ignore_validation [String] Set false not to raise the error when
+    # finding invalid folder name @return [Array<Deliver::AppClipHeaderImage>]
+    # The list of AppClipHeaderImage that exists under given `root` directory
     def self.load_app_clip_header_images(root, ignore_validation)
       app_clip_header_images = language_folders(root, ignore_validation, true).flat_map do |language_folder|
         paths = language_folder.file_paths

deliver/lib/deliver/upload_app_clip_default_experience_metadata.rb

@@ -18,7 +18,7 @@ class UploadAppClipDefaultExperienceMetadata
 
     def upload_metadata(options)
       # app clip default experience metadata is not editable in a live version
-      return if options[:edit_live] || options[:skip_metadata]
+      return if options[:edit_live] || options[:app_clip_default_experience_metadata_path].nil? || options[:skip_metadata]
 
       # load the metadata from the filesystem before uploading
       load_from_filesystem(options)
@@ -70,7 +70,6 @@ def upload_metadata(options)
     # Loads the app clip default experience metadata files and stores them into the options object
     def load_from_filesystem(options)
       metadata_path = options[:app_clip_default_experience_metadata_path]
-      return if options[:skip_metadata] || metadata_path.nil?
 
       # Load localised data
       ignore_validation = options[:ignore_language_directory_validation]

fastlane/lib/fastlane/actions/docs/upload_to_app_store.md.erb

@@ -252,7 +252,7 @@ app_clip_review_information(
 )
 ```
 
-You can also provide these values by creating files in a `metadata/app_clip_review_information/` directory. The file names must match the pattern `<key>.txt` (e.g. `invocation_urls`). The contents of each file will be used as the value for the matching key. Values provided in the `Deliverfile` or `Fastfile` will be take priority over values from these files.
+You can also provide these values by creating files in a `metadata/app_clip_review_information/` directory. The file names must match the pattern `<key>.txt` (e.g. `invocation_urls`). The contents of each file will be used as the value for the matching key. Values provided in the `Deliverfile` or `Fastfile` will take priority over values from these files.
 
 Example of the `invocation_urls.txt` file:
 
@@ -547,7 +547,7 @@ Key | Editable While Live | Directory | Filename | Deprecated Filename
 
 ## Available App Clip Metadata Folder Options
 
-_deliver_ allows for metadata to be set through `.txt` files in the App Clip metadata folder. This folder can be set using `app_clip_default_experience_metadata_path`. Below are all allowed metadata options.
+_deliver_ allows for metadata to be set through `.txt` files in the App Clip metadata folder. This folder can be set using `app_clip_default_experience_metadata_path`. Below are all the allowed metadata options.
 
 ### Non-Localized Metadata
 
@@ -828,8 +828,8 @@ The default App Store Connect behavior is to not carry-over the previous version
 experience metadata. This is a contradictory behavior because it automatically carries over all
 other version metadata when creating a new version.
 
-_deliver_ fixes this issue by default carrying over the previous version's default App Clip
-experience metadata even if the options above are not specified.
+_deliver_ fixes this issue by carrying over the previous version's default App Clip
+experience metadata by default, even if the options above are not specified.
 
 Example usage in your `Deliverfile`: