Closed
Description
@ppkarwasz I have two questions about #175.
- Why are there no
@NonNull
annotations and only@Nullable
annotations, e.g., why isn't itpublic PackageURL(@NonNull String)
? I'd prefer to make it so that anyprivate
APIs could be marked as@NonNull
, at least, since all input for those methods come internally. - Previously, a null
type
orname
produced a checkedMalformedPackageURLException
and now they produce an uncheckedNullPointerException
which in the tests requires catchingNullPointerException
which violates, e.g., DCN_NULLPOINTER_EXCEPTION.I think it's best to put back theMalformedPackageURLException
in the case of the constructors.
Metadata
Metadata
Assignees
Labels
No labels