Apply suggestions from code review

Co-authored-by: Nikola Forró <[email protected]>

Author: lbarcziova

agents/rebase_agent.py

@@ -90,8 +90,8 @@ def get_instructions() -> str:
       6. Upload new upstream sources (files that the `spectool` command downloaded in the previous step)
          to lookaside cache using the `upload_sources` tool.
 
-      7. If you removed any patch files from the spec file (e.g. because they were already applied upstream),
-         you must delete those patch files using `rm` command from the repository as well.
+      7. If you removed any patch file references from the spec file (e.g. because they were already applied upstream),
+         you must remove all the corresponding patch files from the repository as well.
 
       8. Generate a SRPM using `centpkg --name=<PACKAGE> --namespace=rpms --release=<DIST_GIT_BRANCH> srpm`.
 

agents/tasks.py

@@ -84,24 +84,13 @@ async def stage_changes(
     if isinstance(files_to_commit, str):
         files_to_commit = [files_to_commit]
 
-    # Get currently staged files
-    _, stdout, _ = await run_subprocess(
-        ["git", "diff", "--cached", "--name-only"],
-        cwd=local_clone
-    )
-    already_staged = set(stdout.strip().split('\n')) if stdout and stdout.strip() else set()
-
-    # Stage each file
     for file in files_to_commit:
-        if file in already_staged:
-            logger.info(f"Skipping already staged: {file}")
-            continue
-
         logger.info(f"Staging: {file}")
         exit_code, _, stderr = await run_subprocess(
             ["git", "add", "--all", file],
             cwd=local_clone
         )
+        # for the case agent already staged deleted file which leads to error
         if exit_code != 0:
             logger.warning(f"Failed to stage {file}: {stderr}")