Fix the issue with checklist

Also add a check for the duplicate to not post the checklist on multiple
runs

Author: ljavorsk

agents/package_update_steps.py

@@ -4,7 +4,7 @@
 from pydantic import BaseModel, Field
 from pathlib import Path
 
-from common.constants import JiraLabels
+from common.constants import JiraLabels, GITLAB_MR_CHECKLIST
 from common.config import load_rhel_config
 from common.models import LogOutputSchema
 
@@ -143,6 +143,7 @@ async def create_merge_request_checklist(state, next_step, dry_run, gateway_tool
               await tasks.run_tool(
                   "create_merge_request_checklist",
                   merge_request_url=state.merge_request_url,
+                  note_body=GITLAB_MR_CHECKLIST,
                   available_tools=gateway_tools,
               )
               logger.info(f"Created checklist for MR {state.merge_request_url}")

mcp_server/gitlab_tools.py

@@ -305,10 +305,32 @@ async def create_merge_request_checklist(
 ) -> str:
     """
     Creates our pre/post merge checklist for our dist-git merge requests.
+    Checks for existing checklist to avoid duplicates.
     """
     try:
         mr = await _get_merge_request_from_url(merge_request_url)
-        # internal note docs: https://docs.gitlab.com/api/notes/#create-new-issue-note
+
+        def check_existing_checklist():
+            notes = mr._raw_pr.notes.list(get_all=True)
+
+            checklist_body = note_body.strip()
+            if not checklist_body:
+                return False
+            checklist_identifier = checklist_body.splitlines()[0]
+
+            for note in notes:
+                note_body_text = note.body.strip()
+                if (checklist_identifier in note_body_text or
+                        note_body_text == checklist_body):
+                    return True
+
+            return False
+
+        exists = await asyncio.to_thread(check_existing_checklist)
+        if exists:
+            return f"Checklist already exists in merge request {merge_request_url}, not adding duplicate"
+
+        # internal note docs: https://docs.gitlab.com/api/notes/
         await asyncio.to_thread(mr._raw_pr.notes.create, {"body": note_body}, internal=True)
         return f"Successfully created checklist for merge request {merge_request_url}"
     except Exception as e:

mcp_server/tests/unit/test_gitlab_tools.py

@@ -321,9 +321,9 @@ async def test_create_merge_request_checklist():
             flexmock(
                 id=123,
                 _raw_pr=flexmock(
-                    notes=flexmock().should_receive("create").and_return(
-                        flexmock(id=1),
-                    ).mock(),
+                    notes=flexmock()
+                        .should_receive("list").with_args(get_all=True).and_return([]).mock()
+                        .should_receive("create").and_return(flexmock(id=1)).mock(),
                 ),
             ),
         ).mock()
@@ -337,6 +337,37 @@ async def test_create_merge_request_checklist():
     assert result == f"Successfully created checklist for merge request {merge_request_url}"
 
 
+@pytest.mark.asyncio
+async def test_create_merge_request_checklist_duplicate():
+    """Test that duplicate checklists are not created"""
+    merge_request_url = "https://gitlab.com/redhat/rhel/rpms/bash/-/merge_requests/123"
+
+    # Mock an existing note with the checklist identifier
+    existing_note = flexmock(body="# Jötnar MR Review Checklist\n\nSome checklist content")
+
+    flexmock(GitlabService).should_receive("get_project_from_url").with_args(
+        url=merge_request_url.rsplit("/-/merge_requests/", 1)[0],
+    ).and_return(
+        flexmock().should_receive("get_pr").and_return(
+            flexmock(
+                id=123,
+                _raw_pr=flexmock(
+                    notes=flexmock()
+                        .should_receive("list").with_args(get_all=True).and_return([existing_note]).mock(),
+                ),
+            ),
+        ).mock()
+    )
+
+    result = await create_merge_request_checklist(
+        merge_request_url=merge_request_url,
+        note_body=GITLAB_MR_CHECKLIST,
+    )
+
+    assert "already exists" in result
+    assert "not adding duplicate" in result
+
+
 @pytest.mark.asyncio
 async def test_retry_pipeline_job():
     project_url = "https://gitlab.com/redhat/rhel/rpms/bash"