supervisor: Look for Errata Link, not Fixed in Build

Make our "ready to process" state be "Errata Link set" not
"Fixed in Build set", otherwise we can run in the state where
automation has set Fixed in Build but automation has not
yet created an errata.

 - If we move the issue to Integration at this point, then
   'RHEL JIRA Bot" scolds us (https://issues.redhat.com/browse/RHEL-112522)
 - Our testing analyst may get confused.

In the future we'll add tracking for post-merge, pre-ready-to-process
so we can catch the case where the errata never gets created.

Author: owtaylor

supervisor/issue_handler.py

@@ -60,8 +60,13 @@ async def run(self) -> WorkflowResult:
                 "Issue has the jotnar_needs_attention label"
             )
 
+        if issue.errata_link is None:
+            return self.resolve_remove_work_item("Issue has no errata_link")
+
         if issue.fixed_in_build is None:
-            return self.resolve_remove_work_item("Issue has no fixed_in_build")
+            return self.resolve_flag_attention(
+                "Issue has errata_link but no fixed_in_build"
+            )
 
         if issue.preliminary_testing != PreliminaryTesting.PASS:
             return self.resolve_flag_attention(
@@ -85,9 +90,7 @@ async def run(self) -> WorkflowResult:
                 "Preliminary testing has passed, moving to Integration",
             )
         elif issue.status == IssueStatus.INTEGRATION:
-            related_erratum = (
-                get_erratum_for_link(issue.errata_link, full=True) if issue.errata_link else None
-            )
+            related_erratum = get_erratum_for_link(issue.errata_link, full=True)
             testing_analysis = await analyze_issue(issue, related_erratum)
             if testing_analysis.state == TestingState.NOT_RUNNING:
                 return self.resolve_flag_attention(

supervisor/jira_utils.py

@@ -157,7 +157,7 @@ def get_custom_fields() -> dict[str, str]:
 CURRENT_ISSUES_JQL = """
 project = RHEL AND AssignedTeam = rhel-jotnar
 AND status in ('New', 'In Progress', 'Integration', 'Release Pending')
-AND 'Fixed in Build' is not EMPTY
+AND 'Errata Link' is not EMPTY
 AND labels != jotnar_needs_attention
 """
 

supervisor/testing_analyst.py

@@ -24,7 +24,7 @@ class InputSchema(BaseModel):
     test_location_info: TestLocationInfo = Field(
         description="Information about where to find tests and test results"
     )
-    erratum: FullErratum | None = Field(description="Details of the related ERRATUM")
+    erratum: FullErratum = Field(description="Details of the related ERRATUM")
     current_time: datetime = Field(description="Current timestamp")
 
 
@@ -75,7 +75,7 @@ def render_prompt(input: InputSchema) -> str:
     ).render(input)
 
 
-async def analyze_issue(jira_issue: FullIssue, erratum: FullErratum | None) -> OutputSchema:
+async def analyze_issue(jira_issue: FullIssue, erratum: FullErratum) -> OutputSchema:
     agent = ToolCallingAgent(
         llm=ChatModel.from_name(
             os.environ["CHAT_MODEL"],