Skip to content

Commit 7e387a8

Browse files
authored
Fix: Prevent exception being thrown during datetime comparison (#295)
Because publish_date of Erratum is an offset-aware (UTC timezone) datetime object, when we compare it with datetime.min, we have to make datetime.min offset-aware as well.
1 parent 9c6e298 commit 7e387a8

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

supervisor/constants.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
from datetime import datetime, timezone
2+
3+
DATETIME_MIN_UTC = datetime.min.replace(tzinfo=timezone.utc)

supervisor/errata_utils.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
from pydantic import BaseModel
1414
from requests_gssapi import HTTPSPNEGOAuth
1515

16+
from .constants import DATETIME_MIN_UTC
1617
from .http_utils import requests_session
1718
from .supervisor_types import Erratum, FullErratum, ErrataStatus, Comment
1819

@@ -341,7 +342,7 @@ def is_previous_erratum_applicable(erratum_version: str, erratum: Erratum):
341342
if rel_prep:
342343
latest_erratum = max(
343344
rel_prep,
344-
key=lambda e: e.publish_date if e.publish_date else datetime.min,
345+
key=lambda e: e.publish_date if e.publish_date else DATETIME_MIN_UTC,
345346
)
346347
return latest_erratum
347348

0 commit comments

Comments
 (0)