supervisor: Add a helper function for getting advisory url

Adds get_erratum_advisory_url, removes trailing slash from ET_URL,
and updates erratum URL construction across the codebase.

Author: Jazzcort

supervisor/errata_utils.py

@@ -20,7 +20,7 @@
 logger = logging.getLogger(__name__)
 
 
-ET_URL = "https://errata.engineering.redhat.com/"
+ET_URL = "https://errata.engineering.redhat.com"
 
 # regex pattern for extracting timestamps from push logs
 _TIMESTAMP_PATTERN = re.compile(r"(\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}) \+0000")
@@ -117,6 +117,10 @@ def get_utc_timestamp_from_str(timestamp_string: str):
     )
 
 
+def get_erratum_advisory_url(erratum_id: str | int) -> str:
+    return f"{ET_URL}/advisory/{erratum_id}"
+
+
 @overload
 def get_erratum(erratum_id: str | int, full: Literal[False] = False) -> Erratum: ...
 
@@ -155,7 +159,7 @@ def get_erratum(erratum_id: str | int, full: bool = False) -> Erratum | FullErra
     base_erratum = Erratum(
         id=details["id"],
         full_advisory=details["fulladvisory"],
-        url=f"https://errata.engineering.redhat.com/advisory/{erratum_id}",
+        url=get_erratum_advisory_url(erratum_id),
         synopsis=details["synopsis"],
         status=ErrataStatus(details["status"]),
         jira_issues=jira_issues,

supervisor/erratum_handler.py

@@ -19,6 +19,7 @@
     erratum_has_magic_string_in_comments,
     erratum_push_to_stage,
     erratum_refresh_security_alerts,
+    get_erratum_advisory_url,
     get_erratum_build_map,
     get_erratum_transition_rules,
     get_previous_erratum,
@@ -95,7 +96,7 @@ def compare_file_lists(
     comment = (
         f"jotnar-product-listings-checked({current_build.nvr})\n\n"
         f"Compared the file lists for {current_build.nvr} to the file lists for\n"
-        f"{previous_build.nvr} in https://errata.engineering.redhat.com/advisory/{previous_erratum_id} -\n"
+        f"{previous_build.nvr} in {get_erratum_advisory_url(previous_erratum_id)} -\n"
     )
 
     if is_matched: