Apply suggestions from code review

Co-authored-by: Nikola Forró <[email protected]>

Author: lbarcziova

beeai/agents/triage_agent.py

@@ -32,7 +32,7 @@
 logger = logging.getLogger(__name__)
 
 
-def determine_target_branch(cve_eligibility_result: dict | None, triage_data) -> str | None:
+def determine_target_branch(cve_eligibility_result: dict | None, triage_data: BaseModel) -> str | None:
     """
     Determine target branch from fix_version and CVE eligibility.
     """
@@ -72,7 +72,7 @@ def _map_version_to_branch(version: str, needs_internal_fix: bool) -> str | None
 
     if needs_internal_fix:
         branch = f"rhel-{major_version}.{minor_version}"
-        if major_version != "10":
+        if int(major_version) < 10:
             branch += ".0"
         logger.info(f"Mapped {version} -> {branch} (RHEL internal fix)")
     else:

beeai/compose.yaml

@@ -49,7 +49,7 @@ services:
       - ./mcp_server:/home/mcp/mcp_server:ro,z
       - .secrets/keytab:/home/mcp/keytab:ro,z
       - git-repos:/git-repos
-      - .secrets/rhel-config.json:/home/mcp/rhel-config.json:ro,z
+      - .secrets/rhel-config.json:/home/mcp/rhel-config.json:ro,z,U
     command: ["python", "mcp_server/gateway.py"]
     restart: unless-stopped
 

beeai/mcp_server/jira_tools.py

@@ -272,7 +272,10 @@ def check_cve_triage_eligibility(
             "needs_internal_fix": True,
         }
 
-    if major_version == "8":
+    config = _load_rhel_config()
+    current_y_streams = config.get("current_y_streams")
+
+    if not current_y_streams.get(major_version):
         #  no Y-stream, let's skip the other check
         return {
         "is_cve": True,
@@ -283,11 +286,8 @@ def check_cve_triage_eligibility(
 
     due_date = fields.get("duedate")
 
-    config = _load_rhel_config()
     release_dates = config.get("release_dates", {})
 
-    current_y_streams = config.get("current_y_streams")
-
     y_stream_version = current_y_streams.get(major_version)
     y_stream_release_date = release_dates.get(y_stream_version.lower()) if y_stream_version else None