Skip to content

Commit 453ef72

Browse files
committed
Remove cpu limits
We are hitting several cpu limits and weird packit-service behaviour with it. Many resources on internet suggest not to use cpu limits (but instead adjust cpu requests if needed), like this one: https://medium.com/inside-sumup/are-kubernetes-cpu-limits-bad-a04430bf54e1
1 parent 5cc06cb commit 453ef72

17 files changed

+2
-21
lines changed

openshift/dashboard.yml.j2

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ spec:
4848
cpu: "5m"
4949
limits:
5050
memory: "256Mi"
51-
cpu: "50m"
5251
volumes:
5352
- name: packit-secrets
5453
secret:

openshift/flower.yml.j2

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ spec:
4040
cpu: "5m"
4141
limits:
4242
memory: "128Mi"
43-
cpu: "50m"
4443
replicas: 1
4544
strategy:
4645
type: Recreate

openshift/nginx.yml.j2

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,6 @@ spec:
5959
cpu: "5m"
6060
limits:
6161
memory: "32Mi"
62-
cpu: "10m"
6362
replicas: 1
6463
strategy:
6564
type: Recreate

openshift/packit-service-beat.yml.j2

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,6 @@ spec:
7979
ephemeral-storage: "80Ki"
8080
limits:
8181
memory: "256Mi"
82-
cpu: "50m"
8382
replicas: 1
8483
strategy:
8584
type: Recreate

openshift/packit-service-fedmsg.yml.j2

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@ spec:
5555
cpu: "5m"
5656
limits:
5757
memory: "128Mi"
58-
cpu: "50m"
5958
livenessProbe:
6059
exec:
6160
command:

openshift/packit-service.yml.j2

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,6 @@ spec:
104104
# you have to temporarily increase (in webUI/console) the limit
105105
# and once the alembic upgrade passes, revert.
106106
memory: "{{ '4Gi' if project == 'packit--prod' else '512Mi' }}"
107-
cpu: "200m"
108107
# In TLS world, hostname needs to match whatever is set in the cert
109108
# in our cause, k8s is doing here something like curl https://172.15.2.4:8443/api/healthz/
110109
# which will fail TLS validation.
@@ -143,7 +142,7 @@ spec:
143142
readOnly: true
144143
resources:
145144
requests: {memory: "128Mi", cpu: "10m"}
146-
limits: {memory: "128Mi", cpu: "100m"}
145+
limits: {memory: "128Mi"}
147146
{% endif %}
148147
---
149148
apiVersion: v1

openshift/packit-worker.yml.j2

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,6 @@ spec:
166166
cpu: {{ worker_requests_cpu }}
167167
limits:
168168
memory: {{ worker_limits_memory }}
169-
cpu: {{ worker_limits_cpu }}
170169
livenessProbe:
171170
exec:
172171
command:
@@ -197,7 +196,7 @@ spec:
197196
readOnly: true
198197
resources:
199198
requests: {memory: "128Mi", cpu: "10m"}
200-
limits: {memory: "128Mi", cpu: "100m"}
199+
limits: {memory: "128Mi"}
201200
{% endif %}
202201
---
203202
kind: ImageStream

openshift/postgres.yml.j2

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@ spec:
7171
# based on this limit, so keep the limit reasonably high.
7272
memory: "{{ '4Gi' if project == 'packit--prod' else '512Mi' }}"
7373
# Not utilized most of the time, but useful during migrations and for some queries
74-
cpu: "1"
7574
volumeMounts:
7675
- name: postgres-data
7776
mountPath: /var/lib/pgsql/data

openshift/pushgateway.yml.j2

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ spec:
4242
cpu: "5m"
4343
limits:
4444
memory: "32Mi"
45-
cpu: "10m"
4645
replicas: 1
4746
strategy:
4847
type: Recreate

openshift/redict.yml.j2

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ spec:
4343
cpu: "10m"
4444
limits:
4545
memory: "256Mi"
46-
cpu: "10m"
4746
volumes:
4847
- name: redict-pv
4948
persistentVolumeClaim:

0 commit comments

Comments
 (0)