Skip to content

Commit e14347d

Browse files
authored
fix: fix typos in the exceptions for limits (#558)
After switching our deployment to MP+ we (read as “me”) missed some occurences of hardcoded project/namespace for Packit Service deployment. * Fix those typos. * Add warning to the template.
2 parents ef16bbc + 8566f05 commit e14347d

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

openshift/packit-service.yml.j2

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ spec:
8484
# If you see '/usr/bin/run_httpd.sh: line 16: Killed alembic upgrade head'
8585
# you have to temporarily increase (in webUI/console) the limit
8686
# and once the alembic upgrade passes, revert.
87-
memory: "{{ '4Gi' if project == 'packit-prod' else '512Mi' }}"
87+
memory: "{{ '4Gi' if project == 'packit--prod' else '512Mi' }}"
8888
cpu: "200m"
8989
# In TLS world, hostname needs to match whatever is set in the cert
9090
# in our cause, k8s is doing here something like curl https://172.15.2.4:8443/api/healthz/

openshift/postgres.yml.j2

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,12 +53,12 @@ spec:
5353
# - /usr/libexec/check-container
5454
resources:
5555
requests:
56-
memory: "{{ '2Gi' if project == 'packit-prod' else '128Mi' }}"
56+
memory: "{{ '2Gi' if project == 'packit--prod' else '128Mi' }}"
5757
cpu: "30m"
5858
limits:
5959
# The shared_buffers & effective_cache_size values are set by the container
6060
# based on this limit, so keep the limit reasonably high.
61-
memory: "{{ '4Gi' if project == 'packit-prod' else '256Mi' }}"
61+
memory: "{{ '4Gi' if project == 'packit--prod' else '256Mi' }}"
6262
# Not utilized most of the time, but useful during migrations and for some queries
6363
cpu: "1"
6464
volumeMounts:

vars/packit/prod_template.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,9 @@
66
# -------------------------------------------------------------------
77

88
# Openshift project/namespace name
9-
project: packit-prod
9+
# [WARNING] Be careful when changing this value as it is explicitly checked in
10+
# the Packit Service (API) and postgresql deployments
11+
project: packit--prod
1012

1113
# Openshift cluster url
1214
# For the URL of the MP+ API endpoint, see Bitwarden Secure note

0 commit comments

Comments
 (0)