fixup! Enforce strict Optional typing

Author: František Nečas

ogr/abstract.py

@@ -1009,7 +1009,7 @@ def set(
         raise NotImplementedError()
 
     @property
-    def created(self) -> Optional[datetime.datetime]:
+    def created(self) -> datetime.datetime:
         """Datetime of creating the commit status."""
         raise NotImplementedError()
 
@@ -1112,7 +1112,11 @@ def body(self) -> str:
 
     @property
     def git_tag(self) -> GitTag:
-        """Object that represents tag tied to the release."""
+        """Object that represents tag tied to the release.
+
+        Raises:
+            OgrException, if the tag is not found.
+        """
         raise NotImplementedError()
 
     @property
@@ -1337,7 +1341,7 @@ def __init__(
 
                 - GitHub: username or org name.
                 - GitLab: username or org name.
-                - Pagure: namespace (e.g. `"rpms"`). May be none.
+                - Pagure: namespace (e.g. `"rpms"`). May be `None`, i.e. no namespace present.
 
                   In case of forks: `"fork/{username}/{namespace}"`.
         """

ogr/parsing.py

@@ -10,14 +10,14 @@ class RepoUrl:
     Class that represents repo URL.
 
     Attributes:
-        repo (Optional[str]): Name of the repository. Can be None if parsing is being done.
-        namespace (Optional[str]): Namespace of the repository, if has any.
-        username (Optional[str]): Username of the repository owner, if can be
+        repo: Name of the repository. Can be `None` if parsing is being done.
+        namespace: Namespace of the repository, if has any.
+        username: Username of the repository owner, if can be
             specified.
-        is_fork (bool): Flag denoting if repository is a fork, if can be
+        is_fork: Flag denoting if repository is a fork, if can be
             specified (Pagure).
-        hostname (Optional[str]): Hostname of host of the repository.
-        scheme (Optional[str]): Protocol used to access repository.
+        hostname: Hostname of host of the repository.
+        scheme: Protocol used to access repository.
     """
 
     def __init__(

ogr/services/github/flag.py

@@ -9,6 +9,7 @@
 from ogr.abstract import CommitFlag, CommitStatus
 from ogr.services import github as ogr_github
 from ogr.services.base import BaseCommitFlag
+from ogr.exceptions import OgrException
 
 
 class GithubCommitFlag(BaseCommitFlag):
@@ -64,10 +65,10 @@ def set(
         return GithubCommitFlag(project=project, raw_commit_flag=status, commit=commit)
 
     @property
-    def created(self) -> Optional[datetime.datetime]:
-        if self._raw_commit_flag:
-            return self._raw_commit_flag.created_at
-        return None
+    def created(self) -> datetime.datetime:
+        if not self._raw_commit_flag:
+            raise OgrException("Raw commit flag not set, this should not happen.")
+        return self._raw_commit_flag.created_at
 
     @property
     def edited(self) -> Optional[datetime.datetime]:

ogr/services/github/issue.py

@@ -86,7 +86,7 @@ def create(
         body: str,
         private: Optional[bool] = None,
         labels: Optional[List[str]] = None,
-        assignees: Optional[list] = None,
+        assignees: Optional[List[str]] = None,
     ) -> "Issue":
         if private:
             raise OperationNotSupported("Private issues are not supported by Github")

ogr/services/gitlab/flag.py

@@ -3,12 +3,12 @@
 
 import logging
 import datetime
-from typing import List, Optional
+from typing import List
 
 import gitlab
 
 from ogr.abstract import CommitFlag, CommitStatus
-from ogr.exceptions import GitlabAPIException, OperationNotSupported
+from ogr.exceptions import GitlabAPIException, OperationNotSupported, OgrException
 from ogr.services import gitlab as ogr_gitlab
 from ogr.services.base import BaseCommitFlag
 
@@ -93,13 +93,12 @@ def set(
         return GitlabCommitFlag(raw_commit_flag=raw_status, project=project)
 
     @property
-    def created(self) -> Optional[datetime.datetime]:
-        return (
-            datetime.datetime.strptime(
-                self._raw_commit_flag.created_at, "%Y-%m-%dT%H:%M:%S.%fZ"
-            )
-            if self._raw_commit_flag
-            else None
+    def created(self) -> datetime.datetime:
+        if not self._raw_commit_flag:
+            raise OgrException("Raw commit flag not set, this should not happen.")
+
+        return datetime.datetime.strptime(
+            self._raw_commit_flag.created_at, "%Y-%m-%dT%H:%M:%S.%fZ"
         )
 
     @property

ogr/services/gitlab/issue.py

@@ -47,7 +47,7 @@ def url(self) -> str:
         return self._raw_issue.web_url
 
     @property
-    def assignees(self) -> Optional[list]:
+    def assignees(self) -> Optional[List[str]]:
         try:
             return self._raw_issue.assignees
         except AttributeError:

ogr/services/pagure/flag.py

@@ -8,6 +8,7 @@
 from ogr.abstract import CommitFlag, CommitStatus
 from ogr.services import pagure as ogr_pagure
 from ogr.services.base import BaseCommitFlag
+from ogr.exceptions import OgrException
 
 
 class PagureCommitFlag(BaseCommitFlag):
@@ -73,11 +74,11 @@ def set(
         )
 
     @property
-    def created(self) -> Optional[datetime.datetime]:
-        return (
-            datetime.datetime.fromtimestamp(int(self._raw_commit_flag["date_created"]))
-            if self._raw_commit_flag
-            else None
+    def created(self) -> datetime.datetime:
+        if not self._raw_commit_flag:
+            raise OgrException("Raw commit flag not set, this should not happen.")
+        return datetime.datetime.fromtimestamp(
+            int(self._raw_commit_flag["date_created"])
         )
 
     @property

ogr/services/pagure/release.py

@@ -71,8 +71,12 @@ def create(
         message: str,
         ref: Optional[str] = None,
     ) -> "Release":
+        """
+        Raises:
+            ValueError, if ref is not specified.
+        """
         if not ref:
-            raise PagureAPIException("Release ref must be specified")
+            raise ValueError("Release ref must be specified")
         payload = {
             "tagname": tag,
             "commit_hash": ref,