-
Notifications
You must be signed in to change notification settings - Fork 68
Description
Current Forgejo API spec declares that querying for filepaths returns a singular ContentsResponse (i.e., one file), but a comment next to the API call claims it can also return a list of ContentsResponse (and it actually does).
However the generated OpenAPI spec allows only for the singular ContentsResponse which, in turn, makes the pydantic validation (in pyforgejo) fail…
This issue can be “patched” by adjusting the return type in the pyforgejo, even proposed in the PR linked below, but at the same time it implies manual work to be involved with each regeneration of the API via fern for pyforgejo.
TODO
Once this issue gets unblocked:
- Remove the warning from the
ForgejoProject.get_files() - Do not skip the test for
ForgejoProject.get_files() - As for the upstream fix:
- Implement any additional changes, if the API spec gets patched, or
- Open a follow-up issue once the fix (that involves breaking changes) gets to stable
Links
- Outcome of Implement support for Forgejo projects #877
- Related to https://codeberg.org/forgejo/forgejo/issues/7328
- Related to https://codeberg.org/harabat/pyforgejo/issues/11
- Depends on https://codeberg.org/harabat/pyforgejo/pulls/12
Blockers
- Related to https://codeberg.org/forgejo/forgejo/issues/7328
- Related to https://codeberg.org/harabat/pyforgejo/issues/11
- Depends on https://codeberg.org/harabat/pyforgejo/pulls/12
- Release 2.0.1 to Fedora https://src.fedoraproject.org/rpms/python-pyforgejo/pull-request/2
- Depends on pydantic
2.10.6 → 2.11.2
- Depends on pydantic
- Fedora 43 release (ETA October 2025)
Tip
Unblocked for Fedora 43, cannot be unblocked for F42 as it requires next major version of Poetry that's included only in the F43 (aka rawhide as of writing this comment).
Metadata
Metadata
Assignees
Labels
Type
Projects
Status