Use pipeline datetime rather than job submission time to get newer job runs

Signed-off-by: Nikola Forró <nforro@redhat.com>
Assisted-by: Claude Opus 4.6 via Claude Code

Author: nforro

packit_service/models.py

@@ -2383,7 +2383,9 @@ def has_newer_run(cls, run: "CoprBuildTargetModel") -> bool:
         processing results for an older (e.g. canceled) build.
         """
         project_event = run.get_project_event_model()
-        if not project_event or not run.submitted_time:
+        runs = run.group_of_targets.runs if run.group_of_targets else []
+        pipeline_datetime = max((r.datetime for r in runs if r.datetime), default=None)
+        if not project_event or not pipeline_datetime:
             return False
         with sa_session_transaction() as session:
             return session.query(
@@ -2396,7 +2398,7 @@ def has_newer_run(cls, run: "CoprBuildTargetModel") -> bool:
                     ProjectEventModel.event_id == project_event.event_id,
                     CoprBuildTargetModel.identifier == run.identifier,
                     CoprBuildTargetModel.target == run.target,
-                    CoprBuildTargetModel.submitted_time > run.submitted_time,
+                    PipelineModel.datetime > pipeline_datetime,
                     CoprBuildTargetModel.id != run.id,
                 )
                 .exists()
@@ -3051,7 +3053,9 @@ def has_newer_run(cls, run: "KojiBuildTargetModel") -> bool:
         processing results for an older (e.g. canceled) build.
         """
         project_event = run.get_project_event_model()
-        if not project_event or not run.submitted_time:
+        runs = run.group_of_targets.runs if run.group_of_targets else []
+        pipeline_datetime = max((r.datetime for r in runs if r.datetime), default=None)
+        if not project_event or not pipeline_datetime:
             return False
         with sa_session_transaction() as session:
             return session.query(
@@ -3063,7 +3067,7 @@ def has_newer_run(cls, run: "KojiBuildTargetModel") -> bool:
                     ProjectEventModel.type == project_event.type,
                     ProjectEventModel.event_id == project_event.event_id,
                     KojiBuildTargetModel.target == run.target,
-                    KojiBuildTargetModel.submitted_time > run.submitted_time,
+                    PipelineModel.datetime > pipeline_datetime,
                     KojiBuildTargetModel.id != run.id,
                 )
                 .exists()
@@ -3919,7 +3923,9 @@ def has_newer_run(cls, run: "TFTTestRunTargetModel") -> bool:
         processing results for an older (e.g. canceled) run.
         """
         project_event = run.get_project_event_model()
-        if not project_event or not run.submitted_time:
+        runs = run.group_of_targets.runs if run.group_of_targets else []
+        pipeline_datetime = max((r.datetime for r in runs if r.datetime), default=None)
+        if not project_event or not pipeline_datetime:
             return False
         with sa_session_transaction() as session:
             return session.query(
@@ -3932,7 +3938,7 @@ def has_newer_run(cls, run: "TFTTestRunTargetModel") -> bool:
                     ProjectEventModel.event_id == project_event.event_id,
                     TFTTestRunTargetModel.identifier == run.identifier,
                     TFTTestRunTargetModel.target == run.target,
-                    TFTTestRunTargetModel.submitted_time > run.submitted_time,
+                    PipelineModel.datetime > pipeline_datetime,
                     TFTTestRunTargetModel.id != run.id,
                 )
                 .exists()

tests/conftest.py

@@ -396,6 +396,7 @@ def koji_build_pr_downstream():
 
     run_model = flexmock(
         id=3,
+        datetime=datetime.now(),
         job_project_event=project_event_model,
         srpm_build=srpm_build,
         koji_build=koji_build_model,

tests/integration/test_listen_to_fedmsg.py

@@ -2666,6 +2666,7 @@ def test_koji_build_end_downstream(
     flexmock(KojiBuildTargetModel).should_receive("get_by_task_id").and_return(
         koji_build_pr_downstream,
     )
+    flexmock(KojiBuildTargetModel).should_receive("has_newer_run").and_return(False)
     url = koji_build_pr_downstream.web_url
     flexmock(requests).should_receive("get").and_return(requests.Response())
     flexmock(requests.Response).should_receive("raise_for_status").and_return(None)