Support wildcards in COPR allowed list (#2907)

Support wildcards in COPR allowed list

TODO:

 Write new tests or update the old ones to cover new functionality.
 Update doc-strings where appropriate.
 Update or write new documentation in packit/packit.dev.

Fixes #2906
Related to fedora-copr/copr#3804
Merge before/after
RELEASE NOTES BEGIN
Packit now supports wildcards in COPR allow lists
RELEASE NOTES END

Reviewed-by: gemini-code-assist[bot]
Reviewed-by: Evgeni Golov
Reviewed-by: Laura Barcziová
Reviewed-by: nikromen
Reviewed-by: Nikola Forró

Author: centosinfra-prod-github-app[bot]

packit_service/worker/helpers/build/copr_build.py

@@ -1,6 +1,7 @@
 # Copyright Contributors to the Packit project.
 # SPDX-License-Identifier: MIT
 
+import fnmatch
 import logging
 import re
 from collections.abc import Iterable
@@ -388,7 +389,7 @@ def is_forge_project_allowed_to_build_in_copr(self) -> bool:
             self.job_project,
         )
         allowed_projects = copr_project["packit_forge_projects_allowed"]
-        allowed = self.forge_project in allowed_projects
+        allowed = any(fnmatch.fnmatch(self.forge_project, pattern) for pattern in allowed_projects)
         if not allowed:
             logger.warning(
                 f"git-forge project {self.forge_project} "

tests/integration/test_handler.py

@@ -224,7 +224,7 @@ def test_precheck_push(github_push_event):
                 config={"username": "nobody"},
                 project_proxy=flexmock(
                     get=lambda owner, project: {
-                        "packit_forge_projects_allowed": "github.com/packit-service/hello-world",
+                        "packit_forge_projects_allowed": ["github.com/packit-service/hello-world"],
                     },
                 ),
             ),

tests/unit/test_build_helper.py

@@ -2679,7 +2679,7 @@ def test_copr_project_and_namespace(
                     ),
                 },
             ),
-            "",
+            [],
             False,
             id="empty",
         ),
@@ -2694,7 +2694,7 @@ def test_copr_project_and_namespace(
                     ),
                 },
             ),
-            "something/different",
+            ["something/different"],
             False,
             id="not-present",
         ),
@@ -2709,7 +2709,7 @@ def test_copr_project_and_namespace(
                     ),
                 },
             ),
-            "git.instance.io/the/example/namespace/the-example-repo",
+            ["git.instance.io/the/example/namespace/the-example-repo"],
             True,
             id="present",
         ),
@@ -2724,10 +2724,40 @@ def test_copr_project_and_namespace(
                     ),
                 },
             ),
-            "something/different\ngit.instance.io/the/example/namespace/the-example-repo",
+            ["git.instance.io/the/example/namespace/*"],
+            True,
+            id="wildcard",
+        ),
+        pytest.param(
+            JobConfig(
+                type=JobType.copr_build,
+                trigger=JobConfigTriggerType.pull_request,
+                packages={
+                    "package": CommonPackageConfig(
+                        owner="the-owner",
+                        project="the-project",
+                    ),
+                },
+            ),
+            ["something/different", "git.instance.io/the/example/namespace/the-example-repo"],
             True,
             id="present-more-values",
         ),
+        pytest.param(
+            JobConfig(
+                type=JobType.copr_build,
+                trigger=JobConfigTriggerType.pull_request,
+                packages={
+                    "package": CommonPackageConfig(
+                        owner="the-owner",
+                        project="the-project",
+                    ),
+                },
+            ),
+            ["something/different", "git.instance.io/the/example/namespace/*"],
+            True,
+            id="wildcard-more-values",
+        ),
     ],
 )
 def test_check_if_custom_copr_can_be_used_and_report(