Optimize finding build job for scans (#2898)

Optimize finding build job for scans

Reviewed-by: gemini-code-assist[bot]
Reviewed-by: Nikola Forró

Author: softwarefactory-project-zuul[bot]

packit_service/worker/helpers/open_scan_hub.py

@@ -210,21 +210,16 @@ def find_base_build_job(self) -> Optional[JobConfig]:
         (with `commit` trigger and same branch configured as the target PR branch).
         """
         base_build_job = None
+        target_branch = self.copr_build_helper.pull_request_object.target_branch
+        default_branch = self.copr_build_helper.project.default_branch
 
         for job in self.copr_build_helper.package_config.get_job_views():
             if (
                 job.type == JobType.copr_build
                 and job.trigger == JobConfigTriggerType.commit
                 and (
-                    (
-                        job.branch
-                        and job.branch == self.copr_build_helper.pull_request_object.target_branch
-                    )
-                    or (
-                        not job.branch
-                        and self.copr_build_helper.project.default_branch
-                        == self.copr_build_helper.pull_request_object.target_branch
-                    )
+                    (job.branch and job.branch == target_branch)
+                    or (not job.branch and default_branch == target_branch)
                 )
             ):
                 base_build_job = job

tests/unit/test_open_scan_hub.py

@@ -148,6 +148,7 @@ def test_handle_scan(build_models):
     )
 
     project = flexmock(
+        default_branch="main",
         get_pr=lambda pr_id: flexmock(
             target_branch="main",
             target_branch_head_commit="abcdef",