-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow dynamic Copr projects in a custom namespace/group #2431
Comments
Hi, I think this is not entirely a must have but it would be very nice. Instead of |
I am wondering if we should just do the same as Packit and/or allow people to template this (as @pbrezina suggests). Both make some sense and solve this. I would probably start with what Packit does and add templating if needed. The main issue is if it's doable from the permission point of view -- we need to check with the Copr team if it's possible to create projects for another user. (Currently, Packit gets permission for a particular project.) But I hope it's doable for groups. |
Confirmed with Kuba from the Copr team..;( He has suggested a workaround to create a project as Packit and grant the user access. And as I've checked the Copr UI, the groups come from FAS. @pbrezina would it help you to do this inside a FAS group (and add Packit there)? Otherwise, I am worried there isn't much we can do here. |
You mean adding packit user to the FAS group? I don't have a problem with it. |
@pbrezina thanks for a quick response. That's probably the only option that could work. So, just to confirm. Would it still be valuable for you to specify the FAS group as an owner, make Packit a member and use the same naming schema as used for regular Packit-created projects, just in this group? |
You mean it would be |
OK, so we would need to implement templating as well then. I am putting this to backlog for now. Let's see if there is anyone else interested in this but let us know, @pbrezina if this becomes urgent/crutial for you. |
Not urgent, and it is nothing that prevents me from going packit. We are using https://github.com/next-actions/copr that I developed for authselect and sssd that builds pull requests this way and imho it makes sense to implement the templating as a nicer way to organize things but I still see a benefit in using packit instead. |
Currently, it is possible to configure a static custom Copr project using
owner
andproject
options, but it would be nice to allow to set onlyowner
and have projects created dynamically just like Packit does by default, only in that namespace/group.Setting
owner
and notproject
now leads to no jobs being triggered because of an unhandledCoprNoResultException
inCoprBuildJobHelper.is_forge_project_allowed_to_build_in_copr()
:packit-service/packit_service/worker/helpers/build/copr_build.py
Lines 342 to 344 in d95578f
The text was updated successfully, but these errors were encountered: