Skip to content

Commit bc32f52

Browse files
committed
job-cancelling: add notes from the arch
Signed-off-by: Matej Focko <[email protected]>
1 parent 572cd5d commit bc32f52

File tree

1 file changed

+22
-1
lines changed

1 file changed

+22
-1
lines changed

research/ux/job-cancelling.md

Lines changed: 22 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,20 @@ In both cases we should be given previous commit hash.
4545
In the most ideal scenario, we should utilize the provided previous commit, to
4646
find the latest pipeline that might be still running.
4747

48+
:::note Arch discussion
49+
50+
Do not cancel builds/tests on commit trigger for now.
51+
52+
:::
53+
4854
#### Lookup based on the commit hash
4955

56+
:::note Arch discussion
57+
58+
Start with the cheapest approach, i.e., this one.
59+
60+
:::
61+
5062
Finding the latest pipeline that might be still running based on the commit hash
5163
can be done by lookup through `PipelineModel` and `ProjectEventModel` (provided
5264
via `project_event_id`) that has a commit hash attribute.
@@ -76,7 +88,9 @@ _re-releasing_.
7688

7789
### Subsequent jobs
7890

79-
_TODO_
91+
Given the pipelines we store, it shouldn't be hard, basically similar approach
92+
as for cancelling the initial job, just gotta check any other fields in the same
93+
row.
8094

8195
## Cancelling the jobs themselves
8296

@@ -113,6 +127,13 @@ There are multiple API calls:
113127
- cancelling a task - [`cancelTask`](<https://koji.fedoraproject.org/koji/api#:~:text=cancelTask(task_id%2C%20recurse%3DTrue)>)
114128
- cancelling a “full” task - [`cancelTaskFull`](<https://koji.fedoraproject.org/koji/api#:~:text=cancelTaskFull(task_id%2C%20strict%3DTrue)>)
115129

130+
:::note Arch discussion
131+
132+
Do not consider for now, but could be beneficial for saving resources of the
133+
Fedora Infra once we run as a _Fedora CI_.
134+
135+
:::
136+
116137
### VM Image Builder
117138

118139
It **appears** that it is possible to _delete_ a compose:

0 commit comments

Comments
 (0)