Skip to content

Commit 1ec1fd2

Browse files
dcermaknforro
andauthored
Apply suggestions from code review
Co-authored-by: Nikola Forró <[email protected]>
1 parent 5c2890e commit 1ec1fd2

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

specfile/changelog.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,7 @@
3535
"Dec",
3636
)
3737

38-
_OPENSUSE_CHANGELOG_SEPARATOR = (
39-
"-------------------------------------------------------------------"
40-
)
38+
_OPENSUSE_CHANGELOG_SEPARATOR = 67 * "-"
4139

4240

4341
@unique
@@ -206,14 +204,15 @@ def assemble(
206204
Args:
207205
timestamp: Timestamp of the entry.
208206
Supply `datetime` rather than `date` for extended format.
209-
The hour is set to 12 for openSUSE style changelog entries, if a
210-
date is passed instead of a datetime
207+
openSUSE-style changelog entries mandate extended format, so if a `date`
208+
is supplied, the timestamp will be set to noon of that day.
211209
author: Author of the entry.
212210
content: List of lines forming the content of the entry.
213211
evr: EVR (epoch, version, release) of the entry.
212+
Ignored if `style` is `ChangelogStyle.openSUSE`.
214213
day_of_month_padding: Padding to apply to day of month in the timestamp.
215214
append_newline: Whether the entry should be followed by an empty line.
216-
style: Which style of changelog should be created
215+
style: Which style of changelog should be created.
217216
218217
Returns:
219218
New instance of `ChangelogEntry` class.

0 commit comments

Comments
 (0)