Reopen named files also before saving (#470)

Reopen named files also before saving

The underlying file could have been deleted or replaced and its inode may be different, reopening it just before writing should ensure the content is written where it's supposed to.

Reviewed-by: Matej Focko
Reviewed-by: Laura Barcziová

Author: softwarefactory-project-zuul[bot]

plans/packit-integration.fmf

@@ -26,6 +26,8 @@ adjust:
       - how: shell
         script: pip3 install build 'deepdiff < 8.0.0' # version 8.0.0 depends on numpy, avoid it
 
-  - when: "distro == rhel-8 or distro == centos-8 or distro == centos-stream-8"
+  - when: >
+      distro == rhel-8 or distro == centos-8 or distro == centos-stream-8 or
+      distro == rhel-9 or distro == centos-9 or distro == centos-stream-9
     because: "packit doesn't support EL 8"
     enabled: false

specfile/specfile.py

@@ -202,6 +202,12 @@ def _read_lines(cls, file: IO) -> Tuple[List[str], bool]:
             content = raw_content.decode(**cls.ENCODING_ARGS)
         return content.splitlines(), content.endswith("\n")
 
+    def _reopen_named_file(self) -> None:
+        if not self.path:
+            return
+        self._file.close()
+        self._file = self.path.open("r+", **self.ENCODING_ARGS)
+
     @property
     def path(self) -> Optional[Path]:
         """Path to the spec file."""
@@ -263,21 +269,17 @@ def rpm_spec(self) -> rpm.spec:
 
     def reload(self) -> None:
         """Reloads the spec file content."""
-        try:
-            path = Path(cast(FileIO, self._file).name)
-        except AttributeError:
-            pass
-        else:
-            # reopen the path in case the original file has been deleted/replaced
-            self._file.close()
-            self._file = path.open("r+", **self.ENCODING_ARGS)
+        # reopen the path in case the original file has been deleted/replaced
+        self._reopen_named_file()
         self._lines, self._trailing_newline = self._read_lines(self._file)
 
     def save(self) -> None:
         """Saves the spec file content."""
+        content = str(self)
+        # reopen the path in case the original file has been deleted/replaced
+        self._reopen_named_file()
         self._file.seek(0)
         self._file.truncate(0)
-        content = str(self)
         try:
             self._file.write(content)
         except TypeError:

tests/integration/test_specfile.py

@@ -710,3 +710,21 @@ def test_reload(specfile_factory, spec_minimal, spec_traditional, remove_spec):
         after_reload = spec
 
     assert str(before_reload) != str(after_reload)
+
+
+def test_save_after_inode_change(specfile_factory, spec_minimal):
+    spec = specfile_factory(spec_minimal)
+    if spec.path is None:
+        return
+    inode = spec_minimal.stat().st_ino
+    content = spec_minimal.read_bytes()
+    spec_minimal.unlink()
+    spec_minimal.write_bytes(content)
+    assert spec_minimal.stat().st_ino != inode
+    spec.version = "0.2"
+    spec.save()
+    assert all(
+        line.endswith("0.2")
+        for line in spec_minimal.read_text().splitlines()
+        if line.startswith("Version:")
+    )