Skip to content

CI - Applied ruleset for master branch impacts release process #1372

Description

@YOU54F

Similar to pact-foundation/pact_broker#779

package is created and pushed to npm.

updated version and changelog is expected to be pushed back, and release created, however new branch/ci restrictions impacts this from executing successfully

npm notice Publishing to https://registry.npmjs.org/ with tag latest and public access
+ @pact-foundation/pact@14.0.0
    done!
remote: error: GH013: Repository rule violations found for refs/heads/master.        
remote: Review all repository rules at https://github.com/pact-foundation/pact-js/rules?ref=refs%2Fheads%2Fmaster        
remote: 
remote: - Required status check "Test completion check" is expected.        
remote: 
To https://github.com/pact-foundation/pact-js
 * [new tag]           v14.0.0 -> v14.0.0
 ! [remote rejected]   master -> master (push declined due to repository rule violations)
error: failed to push some refs to 'https://github.com/pact-foundation/pact-js'

This has stopped

  • Updated package.json / lockfile from being committed back
  • Updated changelog from being committed back
  • A release from being created, with the appropriate changelog

furthermore, renovate auto-merged a PR after the release, meaning it's awkward to retrospectively update the changelog and version in a sequential manner.

Ideally the release workflow should work as before the new restrictions were applied, or the release workflow should be able to circumvent restrictions.

cc: @JP-Ellis

Metadata

Metadata

Assignees

No one assigned

    Labels

    triageThis issue is yet to be triaged by a maintainer

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions