Skip to content

RFC: Throw explicit timeout errors on verification #534

Open
@isaac-r

Description

@isaac-r

Issue

When running the verifier if the verify method times out there is nothing in the logs to explain the issue is timeout rather than a failing pact verification.

Solution

Add explicit timeout messaging in the Execute method of pact-net\src\PactNet\Verifier\InteropVerifierProvider.cs by passing down the timeout Timespan from pact-net\src\PactNet\Verifier\PactVerifierSource.cs.

Wrapping the result in a try-catch, the explicit timeout exception can be caught and thrown back up.

Further work

I have encountered further issues with no explanations in the errors dure to the limited feedback from the pact-core errors. It would be useful to log config/set up errors with the pact server and return status codes when running the mock server if requests fail or if the application stop unexpectedly.

Alternatives

This could be done in pact-core and updated with additional errors for connection issues to the mock server

Metadata

Metadata

Assignees

No one assigned

    Labels

    triageThis issue is yet to be triaged by a maintainer

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions