Skip to content

Commit 38a284e

Browse files
authored
Merge pull request #801 from tienvx/upgrade-pact-ffi
deps: Upgrade pact ffi to 0.5.4
2 parents 19e6254 + af3b44b commit 38a284e

2 files changed

Lines changed: 4 additions & 5 deletions

File tree

composer.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -244,12 +244,12 @@
244244
"extra": {
245245
"downloads": {
246246
"pact-ffi-headers": {
247-
"version": "0.5.3",
247+
"version": "0.5.4",
248248
"url": "https://github.com/pact-foundation/pact-reference/releases/download/libpact_ffi-v{$version}/pact.h",
249249
"path": "bin/pact-ffi-headers/pact.h"
250250
},
251251
"pact-ffi-lib": {
252-
"version": "0.5.3",
252+
"version": "0.5.4",
253253
"variables": {
254254
"{$prefix}": "PHP_OS_FAMILY === 'Windows' ? 'pact_ffi' : 'libpact_ffi'",
255255
"{$os}": "PHP_OS === 'Darwin' ? 'macos' : strtolower(PHP_OS_FAMILY)",

example/xml/consumer/tests/Service/HttpClientServiceTest.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -155,9 +155,8 @@ public function testGetMovies()
155155
$this->assertCount(2, $movies->movie[0]->characters->character);
156156
$this->assertXmlContent('Big Buck Bunny', $movies->movie[0]->characters->character[0]->name);
157157
$this->assertXmlContent('Jan Morgenstern', $movies->movie[0]->characters->character[0]->actor);
158-
// TODO: investigate why content of the second element (examples = 2) is empty
159-
$this->assertXmlContent('', $movies->movie[0]->characters->character[1]->name);
160-
$this->assertXmlContent('', $movies->movie[0]->characters->character[1]->actor);
158+
$this->assertXmlContent('Big Buck Bunny', $movies->movie[0]->characters->character[1]->name);
159+
$this->assertXmlContent('Jan Morgenstern', $movies->movie[0]->characters->character[1]->actor);
161160
// Generators
162161
$this->assertXmlContentGenerated($movies->movie[0]->{'release-date'});
163162
$this->assertXmlContentGenerated($movies->movie[0]->{'release-date'}[0]->china);

0 commit comments

Comments
 (0)