Skip to content

Commit adabf32

Browse files
stan-is-hateclaude
authored andcommitted
chore(pact_models): use neutral values in arrayContains expression tests
The arrayContains tests I added in #523 used string constants taken from my employer's product domain. They carry no meaning here, so swap them for neutral book-format values. Test data only -- assertions, coverage and parser behaviour are unchanged. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
1 parent 4538b01 commit adabf32

1 file changed

Lines changed: 10 additions & 10 deletions

File tree

rust/pact_models/src/matchingrules/expressions.rs

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2212,14 +2212,14 @@ mod test {
22122212

22132213
#[test]
22142214
fn is_matcher_def_array_contains() {
2215-
assert!(is_matcher_def("arrayContains(matching(equalTo, 'PUBLIC'))"));
2215+
assert!(is_matcher_def("arrayContains(matching(equalTo, 'HARDCOVER'))"));
22162216
assert!(is_matcher_def("arrayContains(matching(equalTo, 'A'), matching(equalTo, 'B'))"));
22172217
assert!(!is_matcher_def("notArrayContains"));
22182218
}
22192219

22202220
#[test]
22212221
fn parse_array_contains_single_variant() {
2222-
let result = parse_matcher_def("arrayContains(matching(equalTo, 'PUBLIC'))").unwrap();
2222+
let result = parse_matcher_def("arrayContains(matching(equalTo, 'HARDCOVER'))").unwrap();
22232223
assert_eq!(result.rules.len(), 1);
22242224
match &result.rules[0] {
22252225
Either::Left(MatchingRule::ArrayContains(variants)) => {
@@ -2232,12 +2232,12 @@ mod test {
22322232
}
22332233
_ => panic!("Expected ArrayContains rule, got {:?}", result.rules[0]),
22342234
}
2235-
assert_eq!(result.value, "PUBLIC");
2235+
assert_eq!(result.value, "HARDCOVER");
22362236
}
22372237

22382238
#[test]
22392239
fn parse_array_contains_multi_variant() {
2240-
let result = parse_matcher_def("arrayContains(matching(equalTo, 'PUBLIC'), matching(equalTo, 'PRIVATE_LINK'))").unwrap();
2240+
let result = parse_matcher_def("arrayContains(matching(equalTo, 'HARDCOVER'), matching(equalTo, 'PAPERBACK'))").unwrap();
22412241
assert_eq!(result.rules.len(), 1);
22422242
match &result.rules[0] {
22432243
Either::Left(MatchingRule::ArrayContains(variants)) => {
@@ -2247,7 +2247,7 @@ mod test {
22472247
}
22482248
_ => panic!("Expected ArrayContains rule"),
22492249
}
2250-
assert_eq!(result.value, "PUBLIC");
2250+
assert_eq!(result.value, "HARDCOVER");
22512251
}
22522252

22532253
#[test]
@@ -2277,20 +2277,20 @@ mod test {
22772277

22782278
#[test]
22792279
fn parse_array_contains_with_regex() {
2280-
let result = parse_matcher_def("arrayContains(matching(regex, 'PUBLIC|PRIVATE.*', 'PUBLIC'))").unwrap();
2280+
let result = parse_matcher_def("arrayContains(matching(regex, 'HARDCOVER|PAPER.*', 'HARDCOVER'))").unwrap();
22812281
assert_eq!(result.rules.len(), 1);
22822282
match &result.rules[0] {
22832283
Either::Left(MatchingRule::ArrayContains(variants)) => {
22842284
assert_eq!(variants.len(), 1);
22852285
let rule_list = variants[0].1.rules.get(&DocPath::root()).unwrap();
22862286
match &rule_list.rules[0] {
2287-
MatchingRule::Regex(re) => assert_eq!(re, "PUBLIC|PRIVATE.*"),
2287+
MatchingRule::Regex(re) => assert_eq!(re, "HARDCOVER|PAPER.*"),
22882288
other => panic!("Expected Regex, got {:?}", other),
22892289
}
22902290
}
22912291
_ => panic!("Expected ArrayContains"),
22922292
}
2293-
assert_eq!(result.value, "PUBLIC");
2293+
assert_eq!(result.value, "HARDCOVER");
22942294
}
22952295

22962296
#[test]
@@ -2301,14 +2301,14 @@ mod test {
23012301

23022302
#[test]
23032303
fn parse_array_contains_combined_with_at_least() {
2304-
let result = parse_matcher_def("atLeast(2), arrayContains(matching(equalTo, 'PUBLIC'))").unwrap();
2304+
let result = parse_matcher_def("atLeast(2), arrayContains(matching(equalTo, 'HARDCOVER'))").unwrap();
23052305
assert!(result.rules.iter().any(|r| matches!(r, Either::Left(MatchingRule::MinType(2)))));
23062306
assert!(result.rules.iter().any(|r| matches!(r, Either::Left(MatchingRule::ArrayContains(_)))));
23072307
}
23082308

23092309
#[test]
23102310
fn parse_array_contains_combined_with_each_value() {
2311-
let result = parse_matcher_def("eachValue(matching(type, 'X')), arrayContains(matching(equalTo, 'PUBLIC'))").unwrap();
2311+
let result = parse_matcher_def("eachValue(matching(type, 'X')), arrayContains(matching(equalTo, 'HARDCOVER'))").unwrap();
23122312
assert!(result.rules.iter().any(|r| matches!(r, Either::Left(MatchingRule::EachValue(_)))));
23132313
assert!(result.rules.iter().any(|r| matches!(r, Either::Left(MatchingRule::ArrayContains(_)))));
23142314
}

0 commit comments

Comments
 (0)