fix: restore latest pact for branch endpoint

There was an overlap when introducing #728

which returns pact versions, not pact publications.

This may have introduced some confusion in #858 with new HAL relations

appended new routes with /versions to match existing pact_publications resource

Author: YOU54F

lib/pact_broker/api.rb

@@ -33,10 +33,10 @@ def self.build_api(application_context = PactBroker::ApplicationContext.default_
         add ["pacts", "provider", :provider_name, "consumer", :consumer_name, "versions"], Api::Resources::PactVersions, {resource_name: "pact_publications"}
         add ["pacts", "provider", :provider_name, "consumer", :consumer_name, "versions", :consumer_version_number], Api::Resources::Pact, {resource_name: "pact_publication", deprecated: true} # Not the standard URL, but keep for backwards compatibility
         add ["pacts", "provider", :provider_name, "consumer", :consumer_name, "tag", :tag], Api::Resources::TaggedPactVersions, {resource_name: "tagged_pact_publications"}
-        add ["pacts", "provider", :provider_name, "consumer", :consumer_name, "branch"], Api::Resources::PactVersionsForBranch, {resource_name: "pact_publications_for_main_branch"}
-        add ["pacts", "provider", :provider_name, "consumer", :consumer_name, "branch", "latest"], Api::Resources::PactVersionsForBranch, {resource_name: "latest_pact_publications_for_main_branch"}
-        add ["pacts", "provider", :provider_name, "consumer", :consumer_name, "branch", :branch_name, "latest"], Api::Resources::PactVersionsForBranch, {resource_name: "latest_pact_publications_for_branch"}
         add ["pacts", "provider", :provider_name, "consumer", :consumer_name, "branch", :branch_name], Api::Resources::PactVersionsForBranch, {resource_name: "pact_publications_for_branch"}
+        add ["pacts", "provider", :provider_name, "consumer", :consumer_name, "branch", "versions"], Api::Resources::PactVersionsForBranch, {resource_name: "pact_publications_for_main_branch"}
+        add ["pacts", "provider", :provider_name, "consumer", :consumer_name, "branch", "latest", "versions"], Api::Resources::PactVersionsForBranch, {resource_name: "latest_pact_publications_for_main_branch"}
+        add ["pacts", "provider", :provider_name, "consumer", :consumer_name, "branch", :branch_name, "latest", "versions"], Api::Resources::PactVersionsForBranch, {resource_name: "latest_pact_publications_for_branch"}
 
         # Pacts
         add ["pacts", "provider", :provider_name, "consumer", :consumer_name, "version", :consumer_version_number], Api::Resources::Pact, {resource_name: "pact_publication"}

lib/pact_broker/api/resources/index.rb

@@ -57,19 +57,19 @@ def links
             },
             "pb:latest-branch-pact-versions" =>
             {
-              href: base_url + "/pacts/provider/{provider}/consumer/{consumer}/branch/{branch}/latest",
+              href: base_url + "/pacts/provider/{provider}/consumer/{consumer}/branch/{branch}/latest/versions",
               title: "Latest version of pact for a provider, for a named consumers branch",
               templated: true
             },
             "pb:main-branch-pact-versions" =>
             {
-              href: base_url + "/pacts/provider/{provider}/consumer/{consumer}/branch",
+              href: base_url + "/pacts/provider/{provider}/consumer/{consumer}/branch/versions",
               title: "All versions of pacts for a provider, for a named consumers main branch",
               templated: true
             },
             "pb:latest-main-branch-pact-versions" =>
             {
-              href: base_url + "/pacts/provider/{provider}/consumer/{consumer}/branch/latest",
+              href: base_url + "/pacts/provider/{provider}/consumer/{consumer}/branch/latest/versions",
               title: "Latest version of pact for a provider, for a named consumers main branch",
               templated: true
             },

lib/pact_broker/doc/views/index/latest-branch-pact-versions.markdown

@@ -2,6 +2,6 @@
 
  Allowed methods: `GET`
 
- Path: `/pacts/provider/{provider}/consumer/{consumer}/branch/{branch}/latest`
+ Path: `/pacts/provider/{provider}/consumer/{consumer}/branch/{branch}/latest/versions`
 
  Returns the latest pact version with the specified consumer, provider and consumer version branch.

lib/pact_broker/doc/views/index/latest-main-branch-pact-versions.markdown

@@ -2,6 +2,6 @@
 
  Allowed methods: `GET`
 
- Path: `/pacts/provider/{provider}/consumer/{consumer}/branch/latest`
+ Path: `/pacts/provider/{provider}/consumer/{consumer}/branch/latest/versions`
 
  Lists all latest pact version with the specified consumer, provider and the consumers main branch.

lib/pact_broker/doc/views/index/main-branch-pact-versions.markdown

@@ -2,6 +2,6 @@
 
  Allowed methods: `GET`
 
- Path: `/pacts/provider/{provider}/consumer/{consumer}/branch`
+ Path: `/pacts/provider/{provider}/consumer/{consumer}/branch/versions`
 
  Lists all the pact versions with the specified consumer, provider and the consumers main branch.