[Refactor] Add player faint count to ArenaData, track total player/enemy faints #5427
+22
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
Why am I making these changes?
playerFaints
was tracked oddly. It's stored by theArena
class but not byArenaData
. This meant it wouldn't save. So instead,playerFaints
was added straight tosessionSaveData
, and theArena
constructor as well asBattleScene.newArena()
required an extra parameter just to passsessionSaveData.playerFaints
.What are the changes from a developer perspective?
ArenaData
class so it's saved and loaded from there instead of at the root of session data.Arena
constructor andBattleScene.newArena()
Screenshots/Videos
How to test the changes?
Checklist
beta
as my base branchnpm run test
)npm run create-test
) or updated existing tests related to the PR's changes?Are there any localization additions or changes? If so: