-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.7.0 #5429
Draft
damocleas
wants to merge
79
commits into
main
Choose a base branch
from
beta
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Release 1.7.0 #5429
+109,746
−130,995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ex (#5328) * Make the name, formName and type readable (bring it infront of larger sprites that would block it) * Dont to type Icons otherwise they will overlay on the "want to go back" text * Update src/ui/pokedex-ui-handler.ts
Main (1.6.4) -> Beta
* Commit old stashed changes * Complete basic implementation of Tera * Fix effectiveness test * Make tera retain until forced recall or faint, regain on biome change * Experimental sparkle fix * Fix champion teras * Attempted fix for double battles tera UI bug * Fix the fix * Fix linting and test issues * Fix more tests * Change int type * Implement tera for ME trainers * Cleanup species inclusivity check * Make tera instant recharge if terapagos in party * Make useless tera shards not generate * Implement stellar tera damage boost * Improve tera selection UI * Tidy up animation and localisation * Improve tera button sprite * Fix Lance tera * Make tera instant recharge during E4 in classic modes. * Fix formatting in the tera common animation The animation was also not playing due to `frameTimedEvents` being missing as well. * Make tera effect start after animation * Implement save migration * Update version number for migration code --------- Co-authored-by: Madmadness65 <[email protected]> Co-authored-by: Madmadness65 <[email protected]>
* Replace integer holder with number holder * Remove duplicate NumberHolder --------- Co-authored-by: Madmadness65 <[email protected]>
… Classic Item Pool (#5353) * Add Tera Orb to Rival * Remove Tera Orb from Classic Rewards
* Update move-touch-controls-handler.ts localization * Update move-touch-controls-handler.ts
Co-authored-by: Jimmybald1 <[email protected]>
* 707 Klefki animation change and removal of experimental need Animation is high enough quality plus personality for the pokemon that there wont be a need to try and make 1 better. this is the best animation for klefki * 704-705 change of exp + 707 Experimental removal * +707 fix a Json over sight and now are displaying properly * 708 animation change and removal of Experimental need Phantump's animation quality is already top notch and dont need to stay in exp prison * 692-693 exp change
* Pancham-exp change * 698 -Exp change and undo experimental need * 703.exp change and undo experimental * 694-exp and removal of experimental * 698-fixing missing pixels and removing uneeded files
* 653-654 exp change * 656 exp change * 664-665 + 663 exp change. Will need to remove Exp need in the future * 714 exp change and removal of Experimental need Its a better improved version of what we already had all around. * 656 exp change + static change Undoing the smiling froakie sadge * 715 files and base fix I fix the sprite bug that has been around for the longest time. HELL YEAH * Finishing touches to 654 variants Gave Braxien tier 2 and tier 3 custom fire color matching the variants for contrast.
* 718 and 718-10 exp change and removal of experimental * 719 exp change and removal of exp * 362-mega exp change * 248-mega exp change * Fix missing pixels on 248-mega back-exp * screwing up the master.json to properly commit it Somehow its ignoring the master.json changes when checking mega tyranitar * Reverted the screw up on Master.json Trying to fix so test check the correct files and not look for a png that dont exists * update the exp-sprites.json after Kev gave me the Info I needed I did this * fix it and pokemonSprites text is passing * Final Adjustment for the colors regarding 248-mega. Adjusted the colors so that it would GLOW and not become darker. --------- Co-authored-by: NightKev <[email protected]>
* [Sprite][Exp change] Gen 6 - Gen 7 * Sylveon new exp * 702 Dedenne * 712-713 exp changes
* Add setAbility method to pokemon.ts * Edit SwitchAbilitiesAttr to use setAbility * Change AbilityGiveAttr to use setAbility * Rename setAbility to be more accurate * Fix AbilityCopyAttr * Fix AbilityChangeAttr * Fix Transform * Fix imposter * Fix PostDefendAbilityGiveAbAttr * Actually fix imposter * Actually fix transform * Fix CopyFaintedAllyAbilityAbAttr * Fix Trace * Fix PostDefendAbilitySwapAbAttr * Add tests for skill swap * Add tests for doodle * Add tests for entrainment * Add tests for role play * Add test for simple beam * Add test for transform * Add test for imposter * Add tests for mummy * Add tests for trace * Add tests for wandering spirit * Consider legendary weather when changing ability * Ensure that passives are not (re)applied when main abilities change * Add general ability swap test cases * Fix test name * Add NoMidTurnActivationAttr * Remove NoMidTurnActivationAttr from illusion * Remove extraneous call to triggerWeatherBasedFormChanges * Fix primal weather clearing * Change "MidTurn" to "OnGain" * Change NoOnGainActivationAttr to a field in PostSummonAbAttr * Add passive support * Remove redundant parentheses Co-authored-by: NightKev <[email protected]> --------- Co-authored-by: damocleas <[email protected]> Co-authored-by: NightKev <[email protected]>
* Add quash logic for single targets * Multi-squash power * Update MovePhase constructor * Start searching from front of phaseQueue instead of weather * Use findPhase instead of looping to search * Basic test case * Test for failure on a already moved target * Speed order test * Fix speed test comment * Fix ForceLastAttr to properly respect speed order * Respect trick room in quash turn order * Test for respecting TR * Add comments, fix var name * Allow for quashed speed ties * Avoid reapplying if a move is already forced last * Spacing * Quash does fail in a single battle despite this not being documented anywhere * Add move text * Update move.ts (readability) Co-authored-by: NightKev <[email protected]> * Use globalScene --------- Co-authored-by: NightKev <[email protected]>
* Update party-exp-bar.ts localizable * Update party-exp-bar.ts
…5361) * summary-ui-handler.ts Lv. and ID No. Text * Remove Lv and ID No. * Remove Lv and ID No.
* Allow tera type choice on starter select * Make tera type actually apply in run * Remove logging statement * Add support for alternate forms
* [Sprite] Vivillion back exp change and scuff fix scuff is the incorrect labeling in the exp-sprite.json. fully updated meadow pattern. all incorrect labeled back sprites are no more a thing. * fix the last issues with Shiny exp backs * Last adjustment for the future variant Pr added 1 color
…ocally. (#5330) * [Misc] Added a Daily Run Seed Override to the overrides. Only works locally. * [Misc] Changed Daily Run Seed Override to string | null Co-authored-by: NightKev <[email protected]> --------- Co-authored-by: Jimmybald1 <[email protected]> Co-authored-by: NightKev <[email protected]> Co-authored-by: damocleas <[email protected]>
#5385) * Base forms are counted as caught when catching a battle form * Ensuring that correct form shows up in Pokédex Index
* Hardcoding Pikachu to show 0 candies * Looking at starterId to determine order in sort by candy
* Introducing list of indices of filtered mons to be passed to the Pokédex Page for scrolling * Update pokedex-page-ui-handler.ts
* Partially implement Teraform Zero ability The functionality of the ability is all there, it just isn't limited to one use per Terastallization yet. * Add the once per battle condition This removes the partial from the ability. * Make attribute names more generic --------- Co-authored-by: damocleas <[email protected]>
* Make moveset gen consider multi hit moves fairly * Make getTargetBenefitScore consider effective power * Apply Kev's suggestions Co-authored-by: NightKev <[email protected]> * Fix improper stat ratio. * Fix expected hit count for pop-bomb like moves Accuracy is now properly divided by 100 * Update src/data/move.ts Co-authored-by: NightKev <[email protected]> * Update src/data/move.ts Co-authored-by: NightKev <[email protected]> * Update src/data/move.ts Co-authored-by: NightKev <[email protected]> --------- Co-authored-by: NightKev <[email protected]>
* Variant json and deletion of the pngs * Variant color adjustment adjusted some color that werent mapped correctly. adjusted some colors due to contrast issues * Fixing the reason sprite test kept failing. .....669
* PokedexMonContainer now has a method to change species. * Not setting tint to 0 in the container * Using only 81 containers in Pokédex * Apply suggestions from code review Co-authored-by: NightKev <[email protected]> --------- Co-authored-by: NightKev <[email protected]>
* Add neutralizing gas arena tag * Add PostSummonAddArenaTagAbAttr * Add PreLeaveField attr for neutralizing gas * Remove old SuppressFieldAbilitiesAttr * Fix ability suppression logic * Add basic tests * Reapply onGain abilities when neutralizing gas ends * Untodo ability remval test * Add more tests * Modify gastro acid to call onLose attributes when suppressing * Properly cancel abilities on switch in * Add documentation * Remove partial designation * Update locale key usage * Reactivate the last source's other abilities when it becomes the last remaining * Fix loop vars * Add access modifiers for SuppressAbilitiesTag * Minor changes * Move test to reflect new location * Remove promises from abattr function signatures
Co-authored-by: damocleas <[email protected]>
* Update egg-moves.ts * Update starters.ts cost changes * Update passives.ts * Update mystery-encounter-utils.test.ts
* Move canApplyAbility check * Fix suppressed abilities not activated properly * Move canApplyAbility to applySingleAbAttrs --------- Co-authored-by: damocleas <[email protected]>
* Make dropdown update selection when reset to default * Function to resect selection in filter bar * Pressing B on filter now closes it or resets instead of going to top of starters * Filter changes to starter select screen * Method to get column at a given index in filter bar * Specific reset behavior for caught filter in starter select menu * Apply suggestions from code review Co-authored-by: NightKev <[email protected]> * Update src/ui/starter-select-ui-handler.ts Co-authored-by: NightKev <[email protected]> --------- Co-authored-by: NightKev <[email protected]> Co-authored-by: damocleas <[email protected]> Co-authored-by: Madmadness65 <[email protected]>
* Shed Tail rounds incurred damage up * Altered Substitute/Shed Tail success condition to account for rounding up * Altered the test to match correct functionality * Update src/data/move.ts Removed default value in constructor due to it having become redundant Co-authored-by: NightKev <[email protected]> --------- Co-authored-by: NightKev <[email protected]> Co-authored-by: Sirz Benjie <[email protected]>
) Co-authored-by: damocleas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
Why am I making these changes?
What are the changes from a developer perspective?
Screenshots/Videos
How to test the changes?
Checklist
beta
as my base branchnpm run test
)npm run create-test
) or updated existing tests related to the PR's changes?Are there any localization additions or changes? If so: