[UI][Enhancement] Implement keybind migrator #5431
Open
+9
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
Whatever key was bound to cycle variant is now bound to cycle tera
Why am I making these changes?
The keybind was changed since cycle variant was no longer in use and we wanted to reuse the key.
What are the changes from a developer perspective?
We want a better way to handle this in the future, but it intercepts setting custom keybinds and replaces given binds.
Screenshots/Videos
How to test the changes?
The only way to test this if you've got a bad keybind is to manually edit your localStorage in the dev tools in order to have a bad keybind by copying it over from main.
Checklist
beta
as my base branchnpm run test
)npm run create-test
) or updated existing tests related to the PR's changes?Are there any localization additions or changes? If so: