Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI][Enhancement] Implement keybind migrator #5431

Open
wants to merge 1 commit into
base: beta
Choose a base branch
from

Conversation

Xavion3
Copy link
Contributor

@Xavion3 Xavion3 commented Feb 27, 2025

What are the changes the user will see?

Whatever key was bound to cycle variant is now bound to cycle tera

Why am I making these changes?

The keybind was changed since cycle variant was no longer in use and we wanted to reuse the key.

What are the changes from a developer perspective?

We want a better way to handle this in the future, but it intercepts setting custom keybinds and replaces given binds.

Screenshots/Videos

image

How to test the changes?

The only way to test this if you've got a bad keybind is to manually edit your localStorage in the dev tools in order to have a bad keybind by copying it over from main.

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes manually?
  • Are all unit tests still passing? (npm run test)
    • Have I created new automated tests (npm run create-test) or updated existing tests related to the PR's changes?
  • Have I provided screenshots/videos of the changes (if applicable)?
    • Have I made sure that any UI change works for both UI themes (default and legacy)?

Are there any localization additions or changes? If so:

  • Has a locales PR been created on the locales repo?
    • If so, please leave a link to it here:
  • Has the translation team been contacted for proofreading/translation?

@Xavion3 Xavion3 requested a review from a team as a code owner February 27, 2025 12:01
@Xavion3 Xavion3 changed the title Implement keybind migrator [Enhancement] Implement keybind migrator Feb 27, 2025
@Xavion3 Xavion3 added Enhancement New feature or request UI/UX User interface/-experience related labels Feb 27, 2025
@Xavion3 Xavion3 changed the title [Enhancement] Implement keybind migrator [UI][Enhancement] Implement keybind migrator Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request UI/UX User interface/-experience related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant