[DEV-3015] Add generic filtered grid #1738
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarBert
requested review from
MarcoPonchia,
marcobottaro and
tommaso1
as code owners
🦋 Changeset detectedLatest commit: 45d593c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
# Conflicts: # apps/nextjs-website/src/components/organisms/FilteredGridLayout/FilteredGridLayout.tsx # apps/nextjs-website/src/components/organisms/TutorialsList/TutorialsList.tsx
Jira Pull Request LinkThis Pull Request refers to the following Jira issue DEV-3015 |
Sebastiano-Bertolin
approved these changes
Oct 17, 2025
tommaso1
requested changes
Oct 17, 2025
| <TutorialsList | ||
| <FilteredGridLayout | ||
| items={mappedTutorials} | ||
| tags={product.tags || []} |
There was a problem hiding this comment.
I would put a default value for tags on the FilteredGridLayout component itself allowing it to take undefined or falsey tags and handle the case with a fallback to empty array in the component
Suggested change
| tags={product.tags || []} | |
| tags={product.tags} |
| <UseCaseList | ||
| <FilteredGridLayout | ||
| items={mappedUseCases} | ||
| tags={product.tags || []} |
There was a problem hiding this comment.
Suggested change
| tags={product.tags || []} | |
| tags={product.tags} |
| readonly useCases: readonly UseCase[]; | ||
| type FilteredGridLayoutProps = { | ||
| readonly items: readonly (INewsroomItem & { tags: readonly Tag[] })[]; | ||
| readonly tags: readonly Tag[]; |
There was a problem hiding this comment.
Would put this optional
Suggested change
| readonly tags: readonly Tag[]; | |
| readonly tags?: readonly Tag[] | null; |
| return ( | ||
| selectedTag === 0 || | ||
| useCase.tags?.some((tag) => tag.name === updatedTags[selectedTag].name) | ||
| item.tags?.some((tag) => tag.name === updatedTags[selectedTag].name) |
There was a problem hiding this comment.
this should already handle the null tags scenario
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
Generalise filtered grid for use cases, tutorials and webinars
Motivation and Context
How Has This Been Tested?
lolcalhost
Screenshots (if appropriate):
Types of changes
Checklist: