Fix artifact name generation and improve change detection logic; update documentation for backend variable file

Author: gunzip

.github/workflows/opex-dashboard-deploy.yaml

@@ -200,7 +200,7 @@ jobs:
         run: |
           # Create a safe artifact name from the dashboard path
           # Replace / and . with - to make it a valid artifact name
-          SAFE_NAME=$(echo "${DASHBOARD_PATH}" | sed 's/[\/.:.]/-/g')
+          SAFE_NAME=$(echo "${DASHBOARD_PATH}" | sed 's/[\/.]/-/g')
           ARTIFACT_NAME="tfplan-${SAFE_NAME}-${GIT_SHA}"
           echo "name=${ARTIFACT_NAME}" >> "$GITHUB_OUTPUT"
           echo "Generated artifact name: ${ARTIFACT_NAME}"
@@ -265,7 +265,7 @@ jobs:
         run: |
           # Create a safe artifact name from the dashboard path (same logic as in plan job)
           # Replace / and . with - to make it a valid artifact name
-          SAFE_NAME=$(echo "${DASHBOARD_PATH}" | sed 's/[\/.:.]/-/g')
+          SAFE_NAME=$(echo "${DASHBOARD_PATH}" | sed 's/[\/.]/-/g')
           ARTIFACT_NAME="tfplan-${SAFE_NAME}-${GIT_SHA}"
           echo "name=${ARTIFACT_NAME}" >> "$GITHUB_OUTPUT"
           echo "Generated artifact name: ${ARTIFACT_NAME}"

actions/opex-dashboard-generate/detect-changes.sh

@@ -48,7 +48,7 @@ if [[ "${BASE_REF}" =~ [^A-Za-z0-9/_^~.-] ]]; then
   echo "::error::BASE_REF may only contain: alphanumeric, hyphen (-), underscore (_), forward slash (/), caret (^), tilde (~), dot (.)"
   exit 1
 fi
-CHANGED_FILES=$(git diff --name-only HEAD "${BASE_REF}" 2>/dev/null || echo "")
+CHANGED_FILES=$(git diff --name-only "${BASE_REF}" HEAD 2>/dev/null || echo "")
 
 echo "Changed files:"
 echo "${CHANGED_FILES}"
@@ -88,7 +88,7 @@ while IFS= read -r config; do
   SHOULD_REGENERATE=false
 
   # Check if config itself was modified
-  if echo "${CHANGED_FILES}" | grep -q "^${config}$"; then
+  if echo "${CHANGED_FILES}" | grep -Fqx "${config}"; then
     echo "Config modified: ${config}"
     SHOULD_REGENERATE=true
   fi
@@ -102,11 +102,17 @@ while IFS= read -r config; do
     fi
 
     if [ -n "${OA3_SPEC}" ]; then
-      # Handle relative paths (relative to workspace root)
-      if [[ "${OA3_SPEC}" != /* ]] && [[ "${OA3_SPEC}" != http* ]]; then
-        OA3_SPEC_FULL=$(normalize_path "${OA3_SPEC}" 2>/dev/null | sed "s|^${WORKSPACE_ROOT}/||" || echo "")
+      # Skip remote specs
+      if [[ "${OA3_SPEC}" != http* ]]; then
+        if [[ "${OA3_SPEC}" = /* ]]; then
+          # Treat absolute repo paths as workspace-root relative by stripping leading slash
+          OA3_SPEC_FULL="${OA3_SPEC#/}"
+        else
+          # Handle relative paths (relative to workspace root)
+          OA3_SPEC_FULL=$(normalize_path "${OA3_SPEC}" 2>/dev/null | sed "s|^${WORKSPACE_ROOT}/||" || echo "")
+        fi
 
-        if [ -n "${OA3_SPEC_FULL}" ] && echo "${CHANGED_FILES}" | grep -q "^${OA3_SPEC_FULL}$"; then
+        if [ -n "${OA3_SPEC_FULL}" ] && echo "${CHANGED_FILES}" | grep -Fqx "${OA3_SPEC_FULL}"; then
           echo "OpenAPI spec modified: ${OA3_SPEC_FULL} (referenced by ${config})"
           SHOULD_REGENERATE=true
         fi

actions/opex-dashboard-generate/extract-directories.sh

@@ -26,7 +26,7 @@ CHANGED_TF_FILES=$(git status --porcelain -- '*.tf' \
   | sed -E 's/.* -> //' || echo "")
 
 if [ -z "${CHANGED_TF_FILES}" ]; then
-  echo "has_changes=true" >> "${GITHUB_OUTPUT}"
+  echo "has_changes=false" >> "${GITHUB_OUTPUT}"
   echo "changed_directories=[]" >> "${GITHUB_OUTPUT}"
   echo "No Terraform files generated (but other files changed)"
   exit 0

apps/website/docs/pipelines/opex-dashboard.md

@@ -219,6 +219,7 @@ paths. Each config directory should contain (or will receive):
 .opex/path/to/dashboard/
 ├── config.yaml          # Dashboard configuration
 ├── backend.tf           # Terraform backend (auto-generated by opex-dashboard or manually created)
+├── backend.tfvars       # Backend variable values (required for terraform init)
 ├── opex.tf              # Generated dashboard Terraform (auto-generated)
 ├── boilerplate.tf       # Provider config (auto-generated)
 ├── variables.tf         # Variable declarations (auto-generated)