fix: remove unused method (#386)

Author: GiovanaSolorzano

src/main/java/it/gov/pagopa/idpay/transactions/service/RewardBatchServiceImpl.java

@@ -518,16 +518,6 @@ public Mono<RewardBatch> approvedTransactions(String rewardBatchId, Transactions
                                 acc.getTrxSuspended())
                 );
     }
-    @Scheduled (cron = "${app.transactions.reward-batch.to-evaluating.schedule}")
-    void evaluatingRewardBatchStatusScheduler(){
-        log.info("[EVALUATING_REWARD_BATCH][SCHEDULER] Start to evaluating all reward batches with status SENT");
-        evaluatingRewardBatches(null)
-                .onErrorResume(RewardBatchNotFound.class, x -> {
-                    log.error("[EVALUATING_REWARD_BATCH][SCHEDULER] " + ERROR_MESSAGE_NOT_FOUND_REWARD_BATCH_SENT, x);
-                    return Mono.just(0L);
-                })
-                .subscribe(numberUpdateBatch -> log.info("[EVALUATING_REWARD_BATCH][SCHEDULER] Completed evaluation. Updated {} reward batches to status EVALUATING", numberUpdateBatch));
-    }
 
     @Override
     public Mono<Long> evaluatingRewardBatches(List<String> rewardBatchesRequest) {

src/main/resources/application.yml

@@ -227,8 +227,4 @@ app:
   delete:
     paginationSize: ${DELETE_PAGINATION_SIZE:45}
     delayTime: ${DELETE_DELAY_TIME:1000}
-  sampling: ${SAMPLING_HASH_SEED:15121984}
-  transactions:
-    reward-batch:
-      to-evaluating:
-        schedule: ${SCHEDULE_REWARD_BATCH_TO_EVALUATING:0 0 1 * * ?} # each day at 01:00AM
+  sampling: ${SAMPLING_HASH_SEED:15121984}

src/test/java/it/gov/pagopa/idpay/transactions/service/RewardBatchServiceImplTest.java

@@ -6,7 +6,6 @@
 import it.gov.pagopa.common.web.exception.*;
 import it.gov.pagopa.idpay.transactions.connector.rest.UserRestClient;
 import it.gov.pagopa.idpay.transactions.dto.ChecksErrorDTO;
-import it.gov.pagopa.idpay.transactions.dto.ReasonDTO;
 import it.gov.pagopa.idpay.transactions.dto.TransactionsRequest;
 import it.gov.pagopa.idpay.transactions.dto.mapper.ChecksErrorMapper;
 import it.gov.pagopa.idpay.transactions.enums.RewardBatchAssignee;
@@ -21,11 +20,6 @@
 import it.gov.pagopa.idpay.transactions.storage.ApprovedRewardBatchBlobService;
 import it.gov.pagopa.idpay.transactions.utils.AuditUtilities;
 import it.gov.pagopa.idpay.transactions.utils.ExceptionConstants;
-import java.lang.reflect.Method;
-import java.time.LocalDate;
-import java.time.LocalDateTime;
-import java.time.YearMonth;
-import java.util.*;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.ExtendWith;
@@ -45,9 +39,17 @@
 import reactor.core.publisher.Mono;
 import reactor.test.StepVerifier;
 
+import java.lang.reflect.Method;
+import java.time.LocalDate;
+import java.time.LocalDateTime;
+import java.time.YearMonth;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+
 import static it.gov.pagopa.idpay.transactions.enums.PosType.PHYSICAL;
-import static it.gov.pagopa.idpay.transactions.utils.ExceptionConstants.ExceptionCode.*;
-import static it.gov.pagopa.idpay.transactions.utils.ExceptionConstants.ExceptionMessage.*;
+import static it.gov.pagopa.idpay.transactions.utils.ExceptionConstants.ExceptionMessage.ERROR_MESSAGE_INVALID_CHECKS_ERROR;
+import static it.gov.pagopa.idpay.transactions.utils.ExceptionConstants.ExceptionMessage.MERCHANT_OR_OPERATOR_HEADER_MANDATORY;
 import static org.junit.jupiter.api.Assertions.*;
 import static org.mockito.ArgumentMatchers.*;
 import static org.mockito.Mockito.*;
@@ -725,16 +727,6 @@ void evaluatingRewardBatches_withList_handlesMissingIdsAsEmpty() {
         verify(rewardBatchRepository, never()).updateStatusAndApprovedAmountCents(any(), any(), anyLong());
     }
 
-    @Test
-    void evaluatingRewardBatchStatusScheduler_handlesRewardBatchNotFoundError() {
-        doReturn(Mono.error(new RewardBatchNotFound(REWARD_BATCH_NOT_FOUND, "x")))
-                .when(serviceSpy).evaluatingRewardBatches(null);
-
-        serviceSpy.evaluatingRewardBatchStatusScheduler();
-
-        verify(serviceSpy).evaluatingRewardBatches(null);
-    }
-
 
     @Test
     void downloadApprovedRewardBatchFile_invalidRequest_missingHeaders() {