Skip to content

Commit 3779b43

Browse files
gquadratiCopilot
andauthored
Apply suggestions from code review
Co-authored-by: Copilot <[email protected]>
1 parent 4220436 commit 3779b43

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

.github/workflows/pr_opex_api_io_sign.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ on:
1010
branches:
1111
- master
1212
paths:
13-
- 'api_io_sign.yaml'
13+
- 'openapi/generated/api_io_sign.yaml'
1414
- '.github/workflows/pr_opex_api_io_sign.yml'
1515
- '.github/workflows/opex_api_io_sign.yml'
1616
- '.opex/api_io_sign/**'

src/routes/ioSignRoutes.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ const IO_SIGN_API_BASE_PATH = "/api/sign/v1";
2626
* AND the legacy routes (/api/v1/sign).
2727
*
2828
* WHY? To prevent accidental divergence during development:
29-
* - When adding/modifying profile endpoints, developers MUST update both versions
29+
* - When adding/modifying IO-Sign endpoints, developers MUST update both versions
3030
* - Having them in the same file makes this requirement explicit and hard to miss
3131
* - Legacy routes will be removed once the Identity API is fully adopted
3232
*
@@ -41,7 +41,7 @@ const IO_SIGN_API_BASE_PATH = "/api/sign/v1";
4141
* @param basePath The base path for the Io Sign APIs
4242
* @param ioSignService The service that handles the Io Sign requests
4343
* @param profileService The service that provides user profiles
44-
* @param authMiddleware The autentication middleware for user session token
44+
* @param authMiddleware The authentication middleware for user session token
4545
* @param lollipopClient The Lollipop client used to communicate with the Lollipop APIs
4646
* @param sessionStorage The session storage used to store user sessions
4747
*/
@@ -110,7 +110,6 @@ export const registerIoSignAPIRoutesLegacy = (
110110
* @param ioSignService The service that handles the Io Sign requests
111111
* @param profileService The service that provides user profiles
112112
* @param lollipopClient The Lollipop client used to communicate with the Lollipop APIs
113-
* @param sessionStorage The session storage used to store user sessions
114113
*/
115114
export const registerIoSignAPIRoutes = (
116115
app: Express,

0 commit comments

Comments
 (0)