P4ADEV-4441-removing-DebtPositionTypeOrg-xsdDefinitionRef

macacia · macacia · commit 90469c914a0a · 2026-02-13T16:34:07.000+01:00
diff --git a/openapi/generated.openapi.json b/openapi/generated.openapi.json
diff --git a/openapi/p4pa-debt-position.openapi.yaml b/openapi/p4pa-debt-position.openapi.yaml
@@ -2639,8 +2639,6 @@ components:
           type: string
         orgSector:
           type: string
-        xsdDefinitionRef:
-          type: string
         amountCents:
           type: integer
           format: int64
diff --git a/postman/p4pa-debt-positions-E2E.postman_collection.json b/postman/p4pa-debt-positions-E2E.postman_collection.json
@@ -669,7 +669,7 @@
 						"header": [],
 						"body": {
 							"mode": "raw",
-							"raw": "{\r\n    \"debtPositionTypeOrg\":{\r\n        \"debtPositionTypeId\": {{debtPositionTypeId}},\r\n        \"organizationId\": {{organizationId}},\r\n        \"balance\": \"\",\r\n        \"code\": \"CODE003\",\r\n        \"description\": \"Test for Save Debt Position Type Org\",\r\n        \"iban\": \"IT60X0542811101000000123456\",\r\n        \"postalIban\": \"IT60X0542811101000000123457\",\r\n        \"postalAccountCode\": \"1234567890\",\r\n        \"holderPostalCc\": \"Holder Postal CC\",\r\n        \"orgSector\": \"Public Sector\",\r\n        \"xsdDefinitionRef\": \"definitionRef123\",\r\n        \"amountCents\": 10000,\r\n        \"externalPaymentUrl\": \"https://example.com/payment\",\r\n        \"flagAnonymousFiscalCode\": false,\r\n        \"flagMandatoryDueDate\": false,\r\n        \"flagSpontaneous\": false,\r\n        \"flagNotifyIo\": true,\r\n        \"ioTemplateMessage\": \"Test IO Message Template\",\r\n        \"flagActive\": true,\r\n        \"flagNotifyOutcomePush\": false,\r\n        \"flagAmountActualization\": false,\r\n        \"flagExternal\": false\r\n    },\r\n    \"enabledOperators\":[\r\n        \"testOperator2\",\r\n        \"testOperator\",\r\n        \"testOperator3\"\r\n    ],\r\n    \"disabledOperators\":[],\r\n    \"removeEnabledOperators\": false\r\n}",
+							"raw": "{\r\n    \"debtPositionTypeOrg\":{\r\n        \"debtPositionTypeId\": {{debtPositionTypeId}},\r\n        \"organizationId\": {{organizationId}},\r\n        \"balance\": \"\",\r\n        \"code\": \"CODE003\",\r\n        \"description\": \"Test for Save Debt Position Type Org\",\r\n        \"iban\": \"IT60X0542811101000000123456\",\r\n        \"postalIban\": \"IT60X0542811101000000123457\",\r\n        \"postalAccountCode\": \"1234567890\",\r\n        \"holderPostalCc\": \"Holder Postal CC\",\r\n        \"orgSector\": \"Public Sector\",\r\n        \"amountCents\": 10000,\r\n        \"externalPaymentUrl\": \"https://example.com/payment\",\r\n        \"flagAnonymousFiscalCode\": false,\r\n        \"flagMandatoryDueDate\": false,\r\n        \"flagSpontaneous\": false,\r\n        \"flagNotifyIo\": true,\r\n        \"ioTemplateMessage\": \"Test IO Message Template\",\r\n        \"flagActive\": true,\r\n        \"flagNotifyOutcomePush\": false,\r\n        \"flagAmountActualization\": false,\r\n        \"flagExternal\": false\r\n    },\r\n    \"enabledOperators\":[\r\n        \"testOperator2\",\r\n        \"testOperator\",\r\n        \"testOperator3\"\r\n    ],\r\n    \"disabledOperators\":[],\r\n    \"removeEnabledOperators\": false\r\n}",
 							"options": {
 								"raw": {
 									"language": "json"
@@ -732,7 +732,7 @@
 						"header": [],
 						"body": {
 							"mode": "raw",
-							"raw": "{\r\n    \"debtPositionTypeOrg\":{\r\n        \"debtPositionTypeOrgId\": {{createdDebtPositionTypeOrgId}},\r\n        \"debtPositionTypeId\": {{debtPositionTypeId}},\r\n        \"organizationId\": {{organizationId}},\r\n        \"balance\": \"\",\r\n        \"code\": \"CODE003\",\r\n        \"description\": \"Test for Save Debt Position Type Org\",\r\n        \"iban\": \"IT60X0542811101000000123456\",\r\n        \"postalIban\": \"IT60X0542811101000000123457\",\r\n        \"postalAccountCode\": \"1234567890\",\r\n        \"holderPostalCc\": \"Holder Postal CC\",\r\n        \"orgSector\": \"Public Sector\",\r\n        \"xsdDefinitionRef\": \"definitionRef123\",\r\n        \"amountCents\": 10000,\r\n        \"externalPaymentUrl\": \"https://example.com/payment\",\r\n        \"flagAnonymousFiscalCode\": false,\r\n        \"flagMandatoryDueDate\": false,\r\n        \"flagSpontaneous\": false,\r\n        \"flagNotifyIo\": true,\r\n        \"ioTemplateMessage\": \"Test IO Message Template\",\r\n        \"flagActive\": true,\r\n        \"flagNotifyOutcomePush\": false,\r\n        \"flagAmountActualization\": false,\r\n        \"flagExternal\": false\r\n    },\r\n    \"enabledOperators\":[\r\n        \"testOperator2\",\r\n        \"testOperator3\",\r\n        \"testOperator4\"\r\n    ],\r\n    \"disabledOperators\":[\r\n        \"testOperator\",\r\n        \"testOperator2\"\r\n    ],\r\n    \"removeEnabledOperators\": false\r\n}",
+							"raw": "{\r\n    \"debtPositionTypeOrg\":{\r\n        \"debtPositionTypeOrgId\": {{createdDebtPositionTypeOrgId}},\r\n        \"debtPositionTypeId\": {{debtPositionTypeId}},\r\n        \"organizationId\": {{organizationId}},\r\n        \"balance\": \"\",\r\n        \"code\": \"CODE003\",\r\n        \"description\": \"Test for Save Debt Position Type Org\",\r\n        \"iban\": \"IT60X0542811101000000123456\",\r\n        \"postalIban\": \"IT60X0542811101000000123457\",\r\n        \"postalAccountCode\": \"1234567890\",\r\n        \"holderPostalCc\": \"Holder Postal CC\",\r\n        \"orgSector\": \"Public Sector\",\r\n        \"amountCents\": 10000,\r\n        \"externalPaymentUrl\": \"https://example.com/payment\",\r\n        \"flagAnonymousFiscalCode\": false,\r\n        \"flagMandatoryDueDate\": false,\r\n        \"flagSpontaneous\": false,\r\n        \"flagNotifyIo\": true,\r\n        \"ioTemplateMessage\": \"Test IO Message Template\",\r\n        \"flagActive\": true,\r\n        \"flagNotifyOutcomePush\": false,\r\n        \"flagAmountActualization\": false,\r\n        \"flagExternal\": false\r\n    },\r\n    \"enabledOperators\":[\r\n        \"testOperator2\",\r\n        \"testOperator3\",\r\n        \"testOperator4\"\r\n    ],\r\n    \"disabledOperators\":[\r\n        \"testOperator\",\r\n        \"testOperator2\"\r\n    ],\r\n    \"removeEnabledOperators\": false\r\n}",
 							"options": {
 								"raw": {
 									"language": "json"
@@ -795,7 +795,7 @@
 						"header": [],
 						"body": {
 							"mode": "raw",
-							"raw": "{\r\n    \"debtPositionTypeOrg\":{\r\n        \"debtPositionTypeOrgId\": {{createdDebtPositionTypeOrgId}},\r\n        \"debtPositionTypeId\": {{debtPositionTypeId}},\r\n        \"organizationId\": {{organizationId}},\r\n        \"balance\": \"\",\r\n        \"code\": \"CODE003\",\r\n        \"description\": \"Test for Save Debt Position Type Org\",\r\n        \"iban\": \"IT60X0542811101000000123456\",\r\n        \"postalIban\": \"IT60X0542811101000000123457\",\r\n        \"postalAccountCode\": \"1234567890\",\r\n        \"holderPostalCc\": \"Holder Postal CC\",\r\n        \"orgSector\": \"Public Sector\",\r\n        \"xsdDefinitionRef\": \"definitionRef123\",\r\n        \"amountCents\": 10000,\r\n        \"externalPaymentUrl\": \"https://example.com/payment\",\r\n        \"flagAnonymousFiscalCode\": false,\r\n        \"flagMandatoryDueDate\": false,\r\n        \"flagSpontaneous\": false,\r\n        \"flagNotifyIo\": true,\r\n        \"ioTemplateMessage\": \"Test IO Message Template\",\r\n        \"flagActive\": true,\r\n        \"flagNotifyOutcomePush\": false,\r\n        \"flagAmountActualization\": false,\r\n        \"flagExternal\": false\r\n    },\r\n    \"enabledOperators\":[\r\n    ],\r\n    \"disabledOperators\":[\r\n    ],\r\n    \"removeEnabledOperators\": true\r\n}",
+							"raw": "{\r\n    \"debtPositionTypeOrg\":{\r\n        \"debtPositionTypeOrgId\": {{createdDebtPositionTypeOrgId}},\r\n        \"debtPositionTypeId\": {{debtPositionTypeId}},\r\n        \"organizationId\": {{organizationId}},\r\n        \"balance\": \"\",\r\n        \"code\": \"CODE003\",\r\n        \"description\": \"Test for Save Debt Position Type Org\",\r\n        \"iban\": \"IT60X0542811101000000123456\",\r\n        \"postalIban\": \"IT60X0542811101000000123457\",\r\n        \"postalAccountCode\": \"1234567890\",\r\n        \"holderPostalCc\": \"Holder Postal CC\",\r\n        \"orgSector\": \"Public Sector\",\r\n        \"amountCents\": 10000,\r\n        \"externalPaymentUrl\": \"https://example.com/payment\",\r\n        \"flagAnonymousFiscalCode\": false,\r\n        \"flagMandatoryDueDate\": false,\r\n        \"flagSpontaneous\": false,\r\n        \"flagNotifyIo\": true,\r\n        \"ioTemplateMessage\": \"Test IO Message Template\",\r\n        \"flagActive\": true,\r\n        \"flagNotifyOutcomePush\": false,\r\n        \"flagAmountActualization\": false,\r\n        \"flagExternal\": false\r\n    },\r\n    \"enabledOperators\":[\r\n    ],\r\n    \"disabledOperators\":[\r\n    ],\r\n    \"removeEnabledOperators\": true\r\n}",
 							"options": {
 								"raw": {
 									"language": "json"
diff --git a/src/main/java/it/gov/pagopa/pu/debtpositions/mapper/DebtPositionTypeOrgMapper.java b/src/main/java/it/gov/pagopa/pu/debtpositions/mapper/DebtPositionTypeOrgMapper.java
@@ -18,7 +18,6 @@ public DebtPositionTypeOrg mapFromDebtPositionType(DebtPositionType debtPosition
       .postalAccountCode(null)
       .holderPostalCc(null)
       .orgSector(null)
-      .xsdDefinitionRef(null)
       .amountCents(null)
       .externalPaymentUrl(null)
       .flagAnonymousFiscalCode(debtPositionType.isFlagAnonymousFiscalCode())
diff --git a/src/main/java/it/gov/pagopa/pu/debtpositions/model/DebtPositionTypeOrg.java b/src/main/java/it/gov/pagopa/pu/debtpositions/model/DebtPositionTypeOrg.java
@@ -39,7 +39,6 @@ public class DebtPositionTypeOrg extends BaseEntity implements Serializable {
   private String postalAccountCode;
   private String holderPostalCc;
   private String orgSector;
-  private String xsdDefinitionRef;
   private Long amountCents;
   private String externalPaymentUrl;
   private boolean flagAnonymousFiscalCode;
diff --git a/src/test/java/it/gov/pagopa/pu/debtpositions/mapper/DebtPositionTypeOrgMapperTest.java b/src/test/java/it/gov/pagopa/pu/debtpositions/mapper/DebtPositionTypeOrgMapperTest.java
@@ -28,7 +28,7 @@ void testMapFromDebtPositionType() {
     //verify
     Assertions.assertNotNull(response);
     TestUtils.checkNotNullFields(response, "debtPositionTypeOrgId", "balance", "iban", "postalIban",
-      "postalAccountCode", "holderPostalCc", "orgSector", "xsdDefinitionRef", "amountCents", "externalPaymentUrl",
+      "postalAccountCode", "holderPostalCc", "orgSector", "amountCents", "externalPaymentUrl",
       "notifyOutcomePushOrgSilServiceId", "amountActualizationOrgSilServiceId", "serviceId", "ioTemplateSubject",
       "creationDate", "updateDate", "updateOperatorExternalId", "updateTraceId", "spontaneousFormId", "allowedEntityType");
   }
diff --git a/src/test/java/it/gov/pagopa/pu/debtpositions/service/DebtPositionTypeOrgServiceImplTest.java b/src/test/java/it/gov/pagopa/pu/debtpositions/service/DebtPositionTypeOrgServiceImplTest.java
@@ -257,7 +257,6 @@ private static DebtPositionTypeOrg buildUpdatedDebtPositionTypeOrg(DebtPositionT
               .postalIban(debtPositionTypeOrg.getPostalIban()+1)
               .postalAccountCode(debtPositionTypeOrg.getPostalAccountCode()+1)
               .holderPostalCc(debtPositionTypeOrg.getHolderPostalCc()+1)
-              .xsdDefinitionRef(debtPositionTypeOrg.getXsdDefinitionRef()+1)
               .amountCents(debtPositionTypeOrg.getAmountCents()+1)
               .externalPaymentUrl(debtPositionTypeOrg.getExternalPaymentUrl()+1)
               .flagSpontaneous(!debtPositionTypeOrg.isFlagSpontaneous())
diff --git a/src/test/java/it/gov/pagopa/pu/debtpositions/util/faker/DebtPositionTypeOrgFaker.java b/src/test/java/it/gov/pagopa/pu/debtpositions/util/faker/DebtPositionTypeOrgFaker.java
@@ -18,7 +18,6 @@ public static DebtPositionTypeOrg buildDebtPositionTypeOrg() {
     debtPositionTypeOrg.setPostalAccountCode("12345678");
     debtPositionTypeOrg.setHolderPostalCc("Test Holder");
     debtPositionTypeOrg.setOrgSector("Finance");
-    debtPositionTypeOrg.setXsdDefinitionRef("definition.xsd");
     debtPositionTypeOrg.setAmountCents(100L);
     debtPositionTypeOrg.setExternalPaymentUrl("https://payment.example.com");
     debtPositionTypeOrg.setFlagAnonymousFiscalCode(true);
@@ -48,7 +47,6 @@ public static DebtPositionTypeOrgDTO buildDebtPositionTypeOrgDTO() {
     debtPositionTypeOrg.setPostalAccountCode("12345678");
     debtPositionTypeOrg.setHolderPostalCc("Test Holder");
     debtPositionTypeOrg.setOrgSector("Finance");
-    debtPositionTypeOrg.setXsdDefinitionRef("definition.xsd");
     debtPositionTypeOrg.setAmountCents(100L);
     debtPositionTypeOrg.setExternalPaymentUrl("https://payment.example.com");
     debtPositionTypeOrg.setFlagAnonymousFiscalCode(true);

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ void testMapFromDebtPositionType() {`
`28`	`28`	`//verify`
`29`	`29`	`Assertions.assertNotNull(response);`
`30`	`30`	`TestUtils.checkNotNullFields(response, "debtPositionTypeOrgId", "balance", "iban", "postalIban",`
`31`		`- "postalAccountCode", "holderPostalCc", "orgSector", "xsdDefinitionRef", "amountCents", "externalPaymentUrl",`
	`31`	`+ "postalAccountCode", "holderPostalCc", "orgSector", "amountCents", "externalPaymentUrl",`
`32`	`32`	`"notifyOutcomePushOrgSilServiceId", "amountActualizationOrgSilServiceId", "serviceId", "ioTemplateSubject",`
`33`	`33`	`"creationDate", "updateDate", "updateOperatorExternalId", "updateTraceId", "spontaneousFormId", "allowedEntityType");`
`34`	`34`	`}`