[PIDM-63] feat(get-ec-by-iban-api): add description field #329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le/entity to /ibans/{iban} API response
src/main/java/it/gov/pagopa/apiconfig/core/model/creditorinstitution/CreditorInstitution.java
Outdated
Show resolved
Hide resolved
| .idDominio("00168480242") | ||
| .enabled(true) | ||
| .ragioneSociale("Comune di Bassano del Grappa") | ||
| .description("Comune di Bassano del Grappa") |
There was a problem hiding this comment.
what's the difference between ragione sociale and description?
There was a problem hiding this comment.
Good point because looking at the h2 mock data from the src/resources/h2/data-h2.sql file, ragioneSociale and description are always populated with the same string. It is just a guess but maybe in production the description field would be used in a different and specific way but I don't have the means to check.
…classes extending CreditorInstitution; remove deNullify from description field; change example for description field;
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
Motivation and Context
This change was required from to have the Creditor Institution description field available in the /ibans/{iban} API response
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: