feat: refactored and simplified code (PIN-9116)

Author: l-giacomini

src/pages/ProviderEServiceSummaryPage/ProviderEServiceSummary.page.tsx

@@ -240,25 +240,17 @@ const ProviderEServiceSummaryPage: React.FC = () => {
     }
   }
 
-  enum Section {
-    GeneralInfoSummary = 'generalInfoSummary',
-    VersionInfoSummary = 'versionInfoSummary',
-    DocumentationSummary = 'documentationSummary',
-  }
+  const isGeneralInfoSectionValid =
+    Boolean(descriptor?.eservice.description) &&
+    Boolean(descriptor?.eservice.technology) &&
+    (FEATURE_FLAG_ESERVICE_PERSONAL_DATA ? arePersonalDataSet : true)
 
-  const isSectionValid = (section: Section) => {
-    const sections = {
-      [Section.GeneralInfoSummary]:
-        !!descriptor?.eservice.description &&
-        !!descriptor?.eservice.technology &&
-        (FEATURE_FLAG_ESERVICE_PERSONAL_DATA ? arePersonalDataSet : true),
-      [Section.VersionInfoSummary]:
-        !!descriptor?.description && !!descriptor?.audience[0] && !!descriptor?.voucherLifespan,
-      [Section.DocumentationSummary]: !!descriptor?.interface,
-    }
+  const isVersionInfoSectionValid =
+    Boolean(descriptor?.description) &&
+    Boolean(descriptor?.audience?.length) &&
+    Boolean(descriptor?.voucherLifespan)
 
-    return sections[section]
-  }
+  const isDocumentationSectionValid = Boolean(descriptor?.interface)
 
   return (
     <>
@@ -304,6 +296,8 @@ const ProviderEServiceSummaryPage: React.FC = () => {
               headline="1"
               title={t('summary.generalInfoSummary.title')}
               defaultExpanded={true}
+              showWarning={!isGeneralInfoSectionValid}
+              warningLabel={t('summary.missingInformationsLabel')}
             >
               <ProviderEServiceGeneralInfoSummary />
             </SummaryAccordion>
@@ -324,7 +318,7 @@ const ProviderEServiceSummaryPage: React.FC = () => {
             <SummaryAccordion
               headline={isReceiveMode ? '4' : '3'}
               title={t('summary.documentationSummary.title')}
-              showWarning={!isSectionValid(Section.DocumentationSummary)}
+              showWarning={!isVersionInfoSectionValid}
               warningLabel={t('summary.missingInformationsLabel')}
             >
               <ProviderEServiceDocumentationSummary />
@@ -334,7 +328,7 @@ const ProviderEServiceSummaryPage: React.FC = () => {
             <SummaryAccordion
               headline={isReceiveMode ? '5' : '4'}
               title={t('summary.versionInfoSummary.title')}
-              showWarning={!isSectionValid(Section.VersionInfoSummary)}
+              showWarning={!isDocumentationSectionValid}
               warningLabel={t('summary.missingInformationsLabel')}
             >
               <ProviderEServiceVersionInfoSummary />

src/pages/ProviderEServiceSummaryPage/components/ProviderEServiceDocumentationSummary.tsx

@@ -39,18 +39,18 @@ export const ProviderEServiceDocumentationSummary: React.FC = () => {
       <Stack spacing={2}>
         <ProviderEServiceInformationContainer
           label={t('interface.label')}
-          content={descriptor.interface?.prettyName}
-        >
-          {descriptor.interface && (
-            <IconLink
-              component="button"
-              startIcon={<AttachFileIcon fontSize="small" />}
-              onClick={handleDownloadDocument.bind(null, descriptor.interface)}
-            >
-              {descriptor.interface.prettyName}
-            </IconLink>
-          )}
-        </ProviderEServiceInformationContainer>
+          content={
+            descriptor.interface && (
+              <IconLink
+                component="button"
+                startIcon={<AttachFileIcon fontSize="small" />}
+                onClick={handleDownloadDocument.bind(null, descriptor.interface)}
+              >
+                {descriptor.interface.prettyName}
+              </IconLink>
+            )
+          }
+        />
         <ProviderEServiceInformationContainer
           label={t('audience.label')}
           content={descriptor.audience[0]}

src/pages/ProviderEServiceSummaryPage/components/ProviderEServiceInformationContainer.tsx

@@ -7,35 +7,31 @@ import { useTranslation } from 'react-i18next'
 
 type ProviderEServiceInformationContainerProps = {
   label: string
-  content?: string
-  children?: React.ReactNode
+  content?: string | JSX.Element
 }
 
 export const ProviderEServiceInformationContainer: React.FC<
   ProviderEServiceInformationContainerProps
-> = ({ label, content, children }) => {
+> = ({ label, content }) => {
   const { t } = useTranslation('eservice')
 
-  if (children) {
-    return (
-      <InformationContainer sx={{ alignItems: 'center' }} label={label} content={<>{children}</>} />
-    )
-  }
-
-  if (content) {
-    return <InformationContainer label={label} content={content} />
-  }
+  const hasContent = content !== null && content !== undefined
 
   return (
     <InformationContainer
+      sx={{ alignItems: 'center' }}
       label={label}
       content={
-        <Stack alignItems="center" spacing={1} direction="row">
-          <ReportProblemOutlinedIcon fontSize="small" color="warning" />
-          <Typography variant="body2" fontWeight={600}>
-            {t('summary.documentationSummary.missingInfoLabel')}
-          </Typography>
-        </Stack>
+        hasContent ? (
+          content
+        ) : (
+          <Stack alignItems="center" spacing={1} direction="row">
+            <ReportProblemOutlinedIcon fontSize="small" color="warning" />
+            <Typography variant="body2" fontWeight={600}>
+              {t('summary.documentationSummary.missingInfoLabel')}
+            </Typography>
+          </Stack>
+        )
       }
     />
   )

src/pages/ProviderEServiceSummaryPage/components/ProviderEServiceVersionInfoSummary.tsx

@@ -43,18 +43,18 @@ export const ProviderEServiceVersionInfoSummary: React.FC = () => {
           <ProviderEServiceInformationContainer
             key={doc.id}
             label={index === 0 ? t('documentation') : ''}
-            content={doc.prettyName}
-          >
-            {descriptor.interface && (
-              <IconLink
-                component="button"
-                startIcon={<AttachFileIcon fontSize="small" />}
-                onClick={handleDownloadDocument.bind(null, doc)}
-              >
-                {doc.prettyName}
-              </IconLink>
-            )}
-          </ProviderEServiceInformationContainer>
+            content={
+              descriptor.interface && (
+                <IconLink
+                  component="button"
+                  startIcon={<AttachFileIcon fontSize="small" />}
+                  onClick={handleDownloadDocument.bind(null, doc)}
+                >
+                  {doc.prettyName}
+                </IconLink>
+              )
+            }
+          />
         ))}
         <ProviderEServiceInformationContainer
           label={t('manualApproval.label')}