Skip to content

Commit 5a1b4d7

Browse files
committed
PN-12231: Fixed @DirtiesContext annotation.
Moved cleanup logic in @beforeeach method.
1 parent 53f3a8f commit 5a1b4d7

File tree

1 file changed

+14
-11
lines changed

1 file changed

+14
-11
lines changed

src/test/java/it/pagopa/pn/ec/cartaceo/service/CartaceoRetryTest.java

Lines changed: 14 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@
1919
import it.pagopa.pn.ec.rest.v1.dto.*;
2020

2121
import it.pagopa.pn.ec.testutils.annotation.SpringBootTestWebEnv;
22-
import org.junit.jupiter.api.AfterEach;
23-
import org.junit.jupiter.api.BeforeAll;
22+
import lombok.CustomLog;
23+
import org.junit.jupiter.api.BeforeEach;
2424
import org.junit.jupiter.api.Test;
2525
import org.junit.jupiter.params.ParameterizedTest;
2626
import org.junit.jupiter.params.provider.Arguments;
@@ -54,7 +54,7 @@
5454
import static org.mockito.Mockito.*;
5555

5656
@SpringBootTestWebEnv
57-
@DirtiesContext
57+
@DirtiesContext(classMode = DirtiesContext.ClassMode.AFTER_EACH_TEST_METHOD)
5858
class CartaceoRetryTest {
5959

6060
@SpyBean
@@ -63,6 +63,12 @@ class CartaceoRetryTest {
6363
@Autowired
6464
private CartaceoSqsQueueName cartaceoSqsQueueName;
6565

66+
@Autowired
67+
DynamoDbEnhancedClient dynamoDbEnhancedClient;
68+
69+
@Autowired
70+
RepositoryManagerDynamoTableName repositoryManagerDynamoTableName;
71+
6672
@SpyBean
6773
CartaceoService cartaceoService;
6874

@@ -98,15 +104,12 @@ class CartaceoRetryTest {
98104
private static DynamoDbTable<RequestConversionEntity> requestConversionEntityDynamoDbAsyncTable;
99105
private static DynamoDbTable<PdfConversionEntity> pdfConversionEntityDynamoDbAsyncTable;
100106

101-
@BeforeAll
102-
static void init(@Autowired DynamoDbEnhancedClient dynamoDbEnhancedClient, @Autowired RepositoryManagerDynamoTableName repositoryManagerDynamoTableName) {
103-
requestConversionEntityDynamoDbAsyncTable = dynamoDbEnhancedClient.table(repositoryManagerDynamoTableName.richiesteConversioneRequestName(), TableSchema.fromBean(RequestConversionEntity.class));
104-
pdfConversionEntityDynamoDbAsyncTable = dynamoDbEnhancedClient.table(repositoryManagerDynamoTableName.richiesteConversionePdfName(), TableSchema.fromBean(PdfConversionEntity.class));
105-
}
106-
107-
@AfterEach
107+
@BeforeEach
108108
void cleanup() {
109+
// Logica di cleanup per evitare che alcuni test influiscano su altri.
109110
ReflectionTestUtils.setField(cartaceoService, "idSaved", null);
111+
requestConversionEntityDynamoDbAsyncTable = dynamoDbEnhancedClient.table(repositoryManagerDynamoTableName.richiesteConversioneRequestName(), TableSchema.fromBean(RequestConversionEntity.class));
112+
pdfConversionEntityDynamoDbAsyncTable = dynamoDbEnhancedClient.table(repositoryManagerDynamoTableName.richiesteConversionePdfName(), TableSchema.fromBean(PdfConversionEntity.class));
110113
for (var page : requestConversionEntityDynamoDbAsyncTable.scan()) {
111114
for (var item : page.items()) {
112115
requestConversionEntityDynamoDbAsyncTable.deleteItem(item);
@@ -516,7 +519,7 @@ private void mockSqsService() {
516519

517520
private void mockGestoreRepository(String clientId, String requestId, RequestDto requestDto) {
518521
// Mock di una generica getRichiesta.
519-
when(gestoreRepositoryCall.getRichiesta(eq(clientId), eq(requestId))).thenReturn(Mono.just(requestDto));
522+
when(gestoreRepositoryCall.getRichiesta(clientId, requestId)).thenReturn(Mono.just(requestDto));
520523

521524
// Mock di una generica patchRichiesta.
522525
when(gestoreRepositoryCall.patchRichiesta(eq(clientId), eq(requestId), any(PatchDto.class))).thenReturn(Mono.just(requestDto));

0 commit comments

Comments
 (0)