PN-11182: split "duplicatesCheck" by ";" to check productType in verificaDuplicati

Author: DamianoLozzi

src/main/java/it/pagopa/pn/ec/consolidatore/service/impl/RicezioneEsitiCartaceoServiceImpl.java

@@ -32,6 +32,7 @@
 import java.time.Duration;
 import java.time.OffsetDateTime;
 import java.util.ArrayList;
+import java.util.Arrays;
 import java.util.List;
 
 import static it.pagopa.pn.ec.commons.constant.Status.BOOKED;
@@ -278,9 +279,13 @@ private Mono<OperationResultCodeResponse> verificaAttachments(
 
 	public Mono<RequestDto> verificaDuplicati(RequestDto requestDto, ConsolidatoreIngressPaperProgressStatusEvent progressStatusEvent) {
 		log.debug(INVOKING_OPERATION_LABEL_WITH_ARGS, VERIFICA_DUPLICATI, progressStatusEvent);
+
+		String[] duplicatesCodes = duplicatesCheck.split(";");
+		boolean shouldCheck= Arrays.stream(duplicatesCodes).anyMatch(code -> code.equals(progressStatusEvent.getProductType()));
+
 		return Mono.defer(() -> {
 			Boolean passthrough = requestDto.getRequestMetadata().getPaperRequestMetadata().getDuplicateCheckPassthrough();
-			if ((passthrough == null || !passthrough) && duplicatesCheck.contains(progressStatusEvent.getProductType())) {
+			if ((passthrough == null || !passthrough) && shouldCheck) {
 				log.debug(VERIFICA_DUPLICATI + ": checking {} for duplicates against events {}", progressStatusEvent,requestDto.getRequestMetadata().getEventsList());
 				return Flux.fromIterable(requestDto.getRequestMetadata().getEventsList()).any(event -> isSameEvent(event.getPaperProgrStatus(), progressStatusEvent));
 			}

src/test/java/it/pagopa/pn/ec/consolidatore/rest/RicezioneEsitiConsolidatoreControllerTest.java

@@ -971,7 +971,7 @@ void ricezioneEsitiDuplicatesCheckActiveConfigNoActivePassthroughKo()  {
 																						.productType(event.getProductType())
 																						.clientRequestTimeStamp(event.getClientRequestTimeStamp())
 		);
-		ReflectionTestUtils.setField(ricezioneEsitiCartaceoServiceImpl, "duplicatesCheck", "ProductType|"+PRODUCT_TYPE_AR+"|OtherProductType");
+		ReflectionTestUtils.setField(ricezioneEsitiCartaceoServiceImpl, "duplicatesCheck", "ProductType;"+PRODUCT_TYPE_AR+";OtherProductType");
 		when(authService.clientAuth(anyString())).thenReturn(Mono.just(clientConfigurationInternalDto));
 		when(gestoreRepositoryCall.getRichiesta(X_PAGOPA_EXTCH_SERVICE_ID_HEADER_VALUE, REQUEST_ID)).thenReturn(Mono.just(getRequestDto(BOOKED_EVENT, SENT_EVENT, con010)));
 		when(statusPullService.paperPullService(anyString(), anyString())).thenReturn(Mono.just(new PaperProgressStatusEvent().productType(PRODUCT_TYPE_AR).iun(IUN)));

src/test/resources/cartaceo/lavorazione-cartaceo.properties

@@ -2,7 +2,7 @@ lavorazione-cartaceo.max-thread-pool-size=${LavorazioneCartaceoMaxThreadPoolSize
 pn.ec.esiti-cartaceo.parameter.name=pn-EC-esitiCartaceo
 ricezione-esiti-pec.consider-event-without-status-as-booked=true
 ricezione-esiti-cartaceo.consider-event-without-sent-status-as-booked=${PnEcRicezioneEsitiCartaceoConsiderEventWithoutSentStatusAsBooked:true}
-ricezione-esiti-cartaceo.duplicates-check=productType1|productType2|productType3
+ricezione-esiti-cartaceo.duplicates-check=productType1;productType2;productType3
 ricezione-esiti-cartaceo.allowed-future-offset-duration=1m
 lavorazione-cartaceo.max-retry-attempts=1
 lavorazione-cartaceo.min-retry-backoff=1