Aggiornamento Validatore 2.5.1 (#170)

* aggiornamento validator 2.5.1, allineato per bug degli stream

* fix

* fix2

* fix3

* fix4

---------

Co-authored-by: MicheleBellizziNTT <MicheleGiorgio.Bellizzi@nttdata.com>

Author: MicheleBellizziNTT

openapi/bundled-api-external-b2b-pa-v2-5.yaml

@@ -12,7 +12,7 @@
         ```
     3.  Run the command to generate the 'bundled-api-external-b2b-pa-v2-4.yaml'
           ```
-          java -jar swagger-codegen-cli-3.0.35.jar generate -l openapi-yaml -i https://raw.githubusercontent.com/pagopa/pn-delivery/develop/docs/openapi/api-external-b2b-pa-bundle.yaml -o . -DoutputFile=bundled-api-external-b2b-pa-v2-4.yaml
+          java -jar swagger-codegen-cli-3.0.35.jar generate -l openapi-yaml -i https://raw.githubusercontent.com/pagopa/pn-delivery/develop/docs/openapi/api-external-b2b-pa-bundle.yaml -o . -DoutputFile=bundled-api-external-b2b-pa-v2-5.yaml
           ```
 3. Then do the modification as below to the generated file.
 4. Add to the `Problem` and `ProblemError` the `type: object` property

openapi/how-to-generate-the-bundled-openapi-definition.md

@@ -1,11 +1,11 @@
 {
   "name": "pn-local-validator",
-  "version": "2.5",
+  "version": "2.5.1",
   "description": "A system that emulates some features of Piattaforma Notifiche platform.",
   "main": "dist/main.js",
   "scripts": {
     "generate": "npm run generate:api && npm run generate:pnapi",
-    "generate:pnapi": "shx rm -rf ./src/generated/pnapi && shx mkdir -p ./src/generated/pnapi && gen-api-models --api-spec ./openapi/bundled-api-external-b2b-pa-v2-4.yaml --no-strict --out-dir ./src/generated/pnapi --request-types --response-decoders",
+    "generate:pnapi": "shx rm -rf ./src/generated/pnapi && shx mkdir -p ./src/generated/pnapi && gen-api-models --api-spec ./openapi/bundled-api-external-b2b-pa-v2-5.yaml --no-strict --out-dir ./src/generated/pnapi --request-types --response-decoders",
     "generate:api": "shx rm -rf ./src/generated/api && shx mkdir -p ./src/generated/api && gen-api-models --api-spec ./openapi/internal.yaml --no-strict --out-dir ./src/generated/api",
     "clean": "tsc --build --clean",
     "postcompile": "shx cp -R ./src/adapters/http/download/exampledocuments ./dist/adapters/http/download/exampledocuments",

package-lock.json

@@ -6,7 +6,7 @@ import * as TE from 'fp-ts/TaskEither';
 import { flow, pipe } from 'fp-ts/function';
 import * as t from 'io-ts';
 import { makeUpdateStreamRecord } from '../../../domain/UpdateStreamRecord';
-import { StreamCreationRequest } from '../../../generated/pnapi/StreamCreationRequest';
+import { StreamCreationRequestV28 } from '../../../generated/pnapi/StreamCreationRequestV28';
 import { updateStreamRecordReturningOnlyTheOneUpdatedStream } from '../../../useCases/PersistRecord';
 import { SystemEnv } from '../../../useCases/SystemEnv';
 import { Handler, toExpressHandler } from '../Handler';
@@ -18,13 +18,19 @@ const handler =
       pipe(
         Apply.sequenceS(E.Apply)({
           apiKey: t.string.decode(req.headers['x-api-key']),
-          body: StreamCreationRequest.decode(req.body),
+          body: StreamCreationRequestV28.decode(req.body),
           streamId: t.string.decode(req.params.streamId),
         }),
-        E.map(flow(makeUpdateStreamRecord(env), updateStreamRecordReturningOnlyTheOneUpdatedStream(env))),
+        // bridge tipizzato per evitare any
+        E.map(
+          flow(
+            (input) => makeUpdateStreamRecord(env)(input), // (input: UpdateStreamRecord['input']) => CreateEventStreamRecord
+            updateStreamRecordReturningOnlyTheOneUpdatedStream(env)
+          )
+        ),
         E.map(
           TE.fold(
-            (_) => T.of(res.status(404).send(Problem.fromNumber(404))),
+            () => T.of(res.status(404).send(Problem.fromNumber(404))),
             ({ output }) => T.of(res.status(output.statusCode).send(output.returned))
           )
         )

package.json

@@ -6,15 +6,15 @@ import { Record, RecordRepository } from '../../domain/Repository';
 import { Logger } from '../../logger';
 import { DeleteStreamRecord } from '../../domain/DeleteStreamRecord';
 import { CreateEventStreamRecord, isCreateEventStreamRecord } from '../../domain/CreateEventStreamRecord';
-import { StreamMetadataResponse } from '../../generated/pnapi/StreamMetadataResponse';
+import { StreamMetadataResponseV28 } from '../../generated/pnapi/StreamMetadataResponseV28';
 import { GetNotificationDetailRecord } from '../../domain/GetNotificationDetailRecord';
-import { FullSentNotificationV21 } from '../../generated/pnapi/FullSentNotificationV21';
-import { NotificationStatusEnum } from '../../generated/pnapi/NotificationStatus';
+import { FullSentNotificationV27 } from '../../generated/pnapi/FullSentNotificationV27';
+import { NotificationStatusV26Enum } from '../../generated/pnapi/NotificationStatusV26';
 
 const filterByStreamId = (streamId: string, record: Record): boolean =>
   O.fold(
     () => true,
-    (csr: CreateEventStreamRecord) => (csr.output.returned as StreamMetadataResponse).streamId !== streamId
+    (csr: CreateEventStreamRecord) => (csr.output.returned as StreamMetadataResponseV28).streamId !== streamId
   )(isCreateEventStreamRecord(record));
 
 // TODO: Instead of mutable variable, try to use the State Monad (or STM)
@@ -51,7 +51,7 @@ export const makeRecordRepository =
       ): TE.TaskEither<Error, ReadonlyArray<Record>> => {
         // Filter out CreateEventStreamRecord with matching streamId
         const filteredStore = store.filter((record) =>
-          filterByStreamId((createEvenStreamRecord.output.returned as StreamMetadataResponse).streamId, record)
+          filterByStreamId((createEvenStreamRecord.output.returned as StreamMetadataResponseV28).streamId, record)
         );
         store = [...filteredStore, createEvenStreamRecord];
         return TE.of(store);
@@ -61,7 +61,7 @@ export const makeRecordRepository =
       ): TE.TaskEither<Error, CreateEventStreamRecord> => {
         // Filter out CreateEventStreamRecord with matching streamId
         const filteredStore = store.filter((record) =>
-          filterByStreamId((createEvenStreamRecord.output.returned as StreamMetadataResponse).streamId, record)
+          filterByStreamId((createEvenStreamRecord.output.returned as StreamMetadataResponseV28).streamId, record)
         );
         if (filteredStore.length === store.length) {
           const error = new Error('No records were updated.');
@@ -75,7 +75,7 @@ export const makeRecordRepository =
         store = [...store, element];
         const getNotificationDetailRecord: GetNotificationDetailRecord = (store.filter(singleRecord => singleRecord.type === 'GetNotificationDetailRecord')[0] as GetNotificationDetailRecord);
         if (getNotificationDetailRecord !== undefined) {
-          (getNotificationDetailRecord.output.returned as FullSentNotificationV21).notificationStatus = NotificationStatusEnum.CANCELLED;
+          (getNotificationDetailRecord.output.returned as FullSentNotificationV27).notificationStatus = NotificationStatusV26Enum.CANCELLED;
         }
         return TE.of(element);
       }