[SELC-6828] Exposed a new boolean test field in getInstitutions (#71)

Author: gaetano-miglionico

apps/institution-ms/app/src/main/docs/openapi.json

@@ -3347,6 +3347,9 @@
           "institutionType" : {
             "type" : "string"
           },
+          "isTest" : {
+            "type" : "boolean"
+          },
           "istatCode" : {
             "type" : "string"
           },

apps/institution-ms/app/src/test/resources/db/institution.json

@@ -503,6 +503,7 @@
       }
     ],
     "imported": false,
+    "isTest": true,
     "createdAt": "2023-11-10T11:45:21.226522053Z",
     "_class": "it.pagopa.selfcare.mscore.connector.dao.model.InstitutionEntity",
     "updatedAt": "2024-06-04T13:39:01.379003912Z",

apps/institution-ms/app/src/test/resources/features/institution.feature

@@ -20,6 +20,8 @@ Feature: Institution
       | 94076720658 |
     And The response body contains at path "institutions.subunitCode" the following list of values in any order:
       | UF5D7W |
+    And The response body contains at path "institutions.isTest" the following list of values in any order:
+      | true |
     And The response body contains the list "institutions[0].onboarding" of size 1
     And The response body contains the list "institutions[1].onboarding" of size 1
     And The response body contains:
@@ -87,6 +89,7 @@ Feature: Institution
       | institutions[0].taxCode                 | 94076720658                          |
       | institutions[0].subunitCode             | UF5D7W                               |
       | institutions[0].onboarding[0].productId | prod-io                              |
+    And The response body doesn't contain field "institutions[0].isTest"
 
   Scenario: Invalid request in getInstitutions with taxCode,origin,originId,subunitCode,productId
     Given User login with username "j.doe" and password "test"
@@ -118,6 +121,7 @@ Feature: Institution
       | institutions[0].origin                  | IPA                                  |
       | institutions[0].originId                | isticom                              |
       | institutions[0].onboarding[0].productId | prod-io                              |
+      | institutions[0].isTest                  | true                                 |
 
   Scenario: Validation error in getInstitutions without taxCode,origin,originId
     Given User login with username "j.doe" and password "test"

apps/institution-ms/connector-api/src/main/java/it/pagopa/selfcare/mscore/model/institution/Institution.java

@@ -50,5 +50,6 @@ public class Institution {
     private String parentDescription;
     private PaAttributes paAttributes;
     private boolean delegation;
+    private Boolean isTest;
 
 }

apps/institution-ms/connector/dao/src/main/java/it/pagopa/selfcare/mscore/connector/dao/model/InstitutionEntity.java

@@ -1,8 +1,8 @@
 package it.pagopa.selfcare.mscore.connector.dao.model;
 
-import it.pagopa.selfcare.onboarding.common.InstitutionType;
 import it.pagopa.selfcare.mscore.connector.dao.model.inner.*;
 import it.pagopa.selfcare.mscore.constant.Origin;
+import it.pagopa.selfcare.onboarding.common.InstitutionType;
 import lombok.Data;
 import lombok.experimental.FieldNameConstants;
 import org.springframework.data.annotation.Id;
@@ -57,5 +57,6 @@ public class InstitutionEntity {
     private String rootParentId;
     private PaAttributesEntity paAttributes;
     private boolean delegation;
+    private Boolean isTest;
 
 }

apps/institution-ms/core/src/test/java/it/pagopa/selfcare/mscore/core/util/TestUtils.java

@@ -1,10 +1,10 @@
 package it.pagopa.selfcare.mscore.core.util;
 
-import it.pagopa.selfcare.onboarding.common.InstitutionType;
 import it.pagopa.selfcare.mscore.constant.Origin;
 import it.pagopa.selfcare.mscore.model.institution.*;
 import it.pagopa.selfcare.mscore.model.onboarding.Contract;
 import it.pagopa.selfcare.mscore.model.onboarding.OnboardingRequest;
+import it.pagopa.selfcare.onboarding.common.InstitutionType;
 
 import java.time.OffsetDateTime;
 import java.util.ArrayList;
@@ -46,7 +46,7 @@ private static Institution dummyInstitution(InstitutionType institutionType) {
                 "The characteristics of someone or something", institutionType, "42 Main St", "42 Main St", "21654",
                 "TaxCode","ivass", "city", "county", "country", "istatCode", billing, onboarding, geographicTaxonomies, attributes, paymentServiceProvider,
                 new DataProtectionOfficer(), null, null, "START - setupCommonData", "START - setupCommonData",
-                "START - setupCommonData", true, OffsetDateTime.now(), OffsetDateTime.now(), null, null, null, null, new PaAttributes(),false);
+                "START - setupCommonData", true, OffsetDateTime.now(), OffsetDateTime.now(), null, null, null, null, new PaAttributes(),false,null);
     }
 
     public static OnboardingRequest dummyOnboardingRequest(Billing billing, Contract contract, InstitutionUpdate institutionUpdate){

apps/institution-ms/web/src/main/java/it/pagopa/selfcare/mscore/web/model/institution/InstitutionResponse.java

@@ -48,5 +48,6 @@ public class InstitutionResponse {
     private OffsetDateTime updatedAt;
     private boolean delegation;
     private String logo;
+    private Boolean isTest;
 
 }